From: Chris Bainbridge <chris.bainbridge@gmail.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Andrew Worsley <amworsley@gmail.com>,
linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org
Subject: Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm
Date: Wed, 25 May 2016 00:38:58 +0100 [thread overview]
Message-ID: <20160524233858.GA5525@localhost> (raw)
In-Reply-To: <20160523144216.GA4894@wunner.de>
On Mon, May 23, 2016 at 04:42:16PM +0200, Lukas Wunner wrote:
>
> The reason why my previous patches didn't work on your machine is
> because you're using grub, and grub contains a patch by Matthew
> Garrett which puts the wireless card into power state D3hot. The
> card's mmio space isn't accessible in D3hot. Included below is a
> new patch which transitions the card to D0 before resetting it.
> Please let me know if this fixes the issue for you.
The grub patch is in Debian but didn't prevent the issue on my setup,
presumably because of the Ubuntu "linuxefi" fallback that Matthew
previously posted about.
> @Chris Bainbridge: Please test this as well, this is no longer a
> plain vanilla PCI quirk but an early quirk, it should prevent any
> kind of memory corruption by DMAed packets.
I tested a "no b43" kernel for 10 boots with and without the patch.
Without the patch: 7 boots had potential memory corruption (caught by
the IOMMU) and all had IRQ 17 disabled.
With the patch: no memory corruption or disabled IRQ 17.
With b43 built in to the kernel wifi worked as expected.
So the patch looks good to me. Thanks for the fix.
Tested-by: Chris Bainbridge <chris.bainbridge@gmail.com> [MacBookPro10,2]
next prev parent reply other threads:[~2016-05-24 23:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1akxli-00030z-BC@bombadil.infradead.org>
2016-03-31 23:13 ` [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm Chris Bainbridge
2016-04-01 4:59 ` Michael Büsch
2016-04-01 22:46 ` Lukas Wunner
2016-04-02 7:30 ` Michael Büsch
[not found] ` <CA+Y=x3=cLDHc7PK5h9n=ixdgVKWdVSu_v+-7jHJ-vBnDrv4sgg@mail.gmail.com>
2016-04-03 11:49 ` Lukas Wunner
2016-04-07 12:04 ` Andrew Worsley
2016-04-10 10:09 ` Andrew Worsley
2016-04-12 18:32 ` Lukas Wunner
2016-04-13 20:42 ` Andrew Worsley
2016-04-24 17:04 ` Lukas Wunner
2016-05-23 14:42 ` Lukas Wunner
2016-05-24 23:38 ` Chris Bainbridge [this message]
[not found] <E1akxli-00030z-Jz@bombadil.infradead.org>
2016-03-31 19:09 ` Michael Büsch
2016-03-29 18:20 Lukas Wunner
2016-03-31 18:51 ` Rafał Miłecki
2016-04-05 19:40 ` Bjorn Helgaas
2016-04-05 19:49 ` Michael Büsch
2016-04-06 13:31 ` Bjorn Helgaas
2016-04-06 15:17 ` Michael Büsch
2016-04-06 21:36 ` Lukas Wunner
2016-04-05 19:59 ` Matthew Garrett
2016-04-06 11:28 ` Andrew Worsley
2016-04-06 21:30 ` Lukas Wunner
2016-04-06 22:19 ` Matthew Garrett
2016-04-09 12:00 ` Matt Fleming
2016-04-24 16:58 ` Lukas Wunner
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 17:46 Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524233858.GA5525@localhost \
--to=chris.bainbridge@gmail.com \
--cc=amworsley@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).