From: "Michael Büsch" <m@bues.ch>
To: "Hugh Sipière" <hgsipiere@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: ssb: Fix comments to suit coding style
Date: Sat, 4 Jun 2016 13:50:10 +0200 [thread overview]
Message-ID: <20160604135010.4066a7a6@wiggum> (raw)
In-Reply-To: <1465039933-3984-1-git-send-email-hgsipiere@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
On Sat, 4 Jun 2016 12:32:13 +0100
Hugh Sipière <hgsipiere@gmail.com> wrote:
> I changed it so that these two comments do not end on a line with text.
>
> Signed-off-by: Hugh Sipière <hgsipiere@gmail.com>
> ---
> drivers/ssb/driver_gpio.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c
> index 180e027..f2435f3 100644
> --- a/drivers/ssb/driver_gpio.c
> +++ b/drivers/ssb/driver_gpio.c
> @@ -231,7 +231,8 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus)
> chip->ngpio = 16;
> /* There is just one SoC in one device and its GPIO addresses should be
> * deterministic to address them more easily. The other buses could get
> - * a random base number. */
> + * a random base number.
> + */
> if (bus->bustype == SSB_BUSTYPE_SSB)
> chip->base = 0;
> else
> @@ -424,7 +425,8 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
> chip->ngpio = 5;
> /* There is just one SoC in one device and its GPIO addresses should be
> * deterministic to address them more easily. The other buses could get
> - * a random base number. */
> + * a random base number.
> + */
> if (bus->bustype == SSB_BUSTYPE_SSB)
> chip->base = 0;
> else
What's the benefit from this change?
Will the next person submit a patch to remove wasted lines that just
contain a */?
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-04 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 11:32 [PATCH] drivers: ssb: Fix comments to suit coding style Hugh Sipière
2016-06-04 11:50 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604135010.4066a7a6@wiggum \
--to=m@bues.ch \
--cc=hgsipiere@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).