linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: ssb: Fix comments to suit coding style
@ 2016-06-04 11:32 Hugh Sipière
  2016-06-04 11:50 ` Michael Büsch
  0 siblings, 1 reply; 2+ messages in thread
From: Hugh Sipière @ 2016-06-04 11:32 UTC (permalink / raw)
  To: m; +Cc: linux-wireless, linux-kernel, Hugh Sipière

I changed it so that these two comments do not end on a line with text.

Signed-off-by: Hugh Sipière <hgsipiere@gmail.com>
---
 drivers/ssb/driver_gpio.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c
index 180e027..f2435f3 100644
--- a/drivers/ssb/driver_gpio.c
+++ b/drivers/ssb/driver_gpio.c
@@ -231,7 +231,8 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus)
 	chip->ngpio		= 16;
 	/* There is just one SoC in one device and its GPIO addresses should be
 	 * deterministic to address them more easily. The other buses could get
-	 * a random base number. */
+	 * a random base number.
+	 */
 	if (bus->bustype == SSB_BUSTYPE_SSB)
 		chip->base		= 0;
 	else
@@ -424,7 +425,8 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
 	chip->ngpio		= 5;
 	/* There is just one SoC in one device and its GPIO addresses should be
 	 * deterministic to address them more easily. The other buses could get
-	 * a random base number. */
+	 * a random base number.
+	 */
 	if (bus->bustype == SSB_BUSTYPE_SSB)
 		chip->base		= 0;
 	else
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: ssb: Fix comments to suit coding style
  2016-06-04 11:32 [PATCH] drivers: ssb: Fix comments to suit coding style Hugh Sipière
@ 2016-06-04 11:50 ` Michael Büsch
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2016-06-04 11:50 UTC (permalink / raw)
  To: Hugh Sipière; +Cc: linux-wireless, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

On Sat,  4 Jun 2016 12:32:13 +0100
Hugh Sipière <hgsipiere@gmail.com> wrote:

> I changed it so that these two comments do not end on a line with text.
> 
> Signed-off-by: Hugh Sipière <hgsipiere@gmail.com>
> ---
>  drivers/ssb/driver_gpio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c
> index 180e027..f2435f3 100644
> --- a/drivers/ssb/driver_gpio.c
> +++ b/drivers/ssb/driver_gpio.c
> @@ -231,7 +231,8 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus)
>  	chip->ngpio		= 16;
>  	/* There is just one SoC in one device and its GPIO addresses should be
>  	 * deterministic to address them more easily. The other buses could get
> -	 * a random base number. */
> +	 * a random base number.
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_SSB)
>  		chip->base		= 0;
>  	else
> @@ -424,7 +425,8 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
>  	chip->ngpio		= 5;
>  	/* There is just one SoC in one device and its GPIO addresses should be
>  	 * deterministic to address them more easily. The other buses could get
> -	 * a random base number. */
> +	 * a random base number.
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_SSB)
>  		chip->base		= 0;
>  	else


What's the benefit from this change?
Will the next person submit a patch to remove wasted lines that just
contain a */?


-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-04 11:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-04 11:32 [PATCH] drivers: ssb: Fix comments to suit coding style Hugh Sipière
2016-06-04 11:50 ` Michael Büsch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).