From: Jouni Malinen <j@w1.fi>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames
Date: Tue, 21 Jun 2016 00:25:29 +0300 [thread overview]
Message-ID: <20160620212529.GA19076@w1.fi> (raw)
In-Reply-To: <57673E10.7070706@gmail.com>
On Mon, Jun 20, 2016 at 09:51:28AM +0900, Masashi Honma wrote:
> On 2016年06月18日 18:11, Jouni Malinen wrote:
> Yes. This patch breaks backward compatibility.
> I do not have smart idea to avoid also.
> I will create new define like this.
> CONFIG_MAC80211_MESH_GROUP_ADDRESSED_PRIVACY
Do we really want that? Group addressed privacy is what the standard
requires to be used with mesh and if we make it build time configurable,
we'll just end up with two different implementation that will never
interoperate with each other.. I don't really see any better option for
this apart from fixing this and requiring all STAs in a secure mesh to
be updated in synchronized manner. This way it will be a one time issue,
but that won't be there forever.
If something is needed to for temporary backwards compatibility support,
that should be something that can be enabled at runtime (and be disabled
by default). That said, I'm not sure I'd go with that extra complexity
taken into account how badly (i.e., completely incorrectly) the PMF case
was implemented in wpa_supplicant. I'm not planning on adding any
backwards compatibility mode there for due to the previous behavior not
really being good from security view point either (using the same key
with two different algorithms).
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2016-06-20 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 5:38 [PATCH] mac80211: Encrypt "Group addressed privacy" action frames Masashi Honma
2016-06-18 9:11 ` Jouni Malinen
2016-06-20 0:51 ` Masashi Honma
2016-06-20 21:25 ` Jouni Malinen [this message]
2016-06-21 6:16 ` Masashi Honma
2016-06-21 17:01 ` Jouni Malinen
2016-06-21 19:40 ` Johannes Berg
2016-06-22 10:54 ` Masashi Honma
2016-06-22 10:55 ` [PATCH v3] " Masashi Honma
2016-06-29 15:08 ` Masashi Honma
2016-06-29 16:25 ` Johannes Berg
2016-06-29 23:20 ` Masashi Honma
2016-06-21 6:23 ` [PATCH v2] " Masashi Honma
2016-06-21 16:42 ` Jouni Malinen
2016-06-22 10:53 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620212529.GA19076@w1.fi \
--to=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).