From: Dan Carpenter <dan.carpenter@oracle.com>
To: arend@broadcom.com
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: re: net: wireless: add brcm80211 drivers
Date: Mon, 27 Jun 2016 16:22:21 +0300 [thread overview]
Message-ID: <20160627132221.GA1114@mwanda> (raw)
Hello Arend van Spriel,
The patch 5b435de0d786: "net: wireless: add brcm80211 drivers" from
Oct 5, 2011, leads to the following static checker warning:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26460 wlc_phy_rxcal_radio_setup_nphy()
warn: mask and shift to zero
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
26452 } else {
26453 pi->tx_rx_cal_radio_saveregs[4] =
26454 read_radio_reg(pi,
26455 RADIO_2056_RX_LNAA_TUNE
26456 | RADIO_2056_RX0);
26457
26458 offtune_val =
26459 (pi->tx_rx_cal_radio_saveregs
26460 [2] & 0xF0) >> 8;
This is obviously nonsense code, but I have no idea what was intended.
26461 offtune_val =
26462 (offtune_val <= 0x7) ? 0xF : 0;
This is perhaps a bug fix/work around for the earlier line.
26463
26464 mod_radio_reg(pi,
26465 RADIO_2056_RX_LNAA_TUNE |
26466 RADIO_2056_RX0, 0xF0,
26467 (offtune_val << 8));
26468 }
regards,
dan carpenter
next reply other threads:[~2016-06-27 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:22 Dan Carpenter [this message]
2016-06-27 19:12 ` net: wireless: add brcm80211 drivers Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2012-08-05 19:57 Dan Carpenter
2012-08-06 8:50 ` Arend van Spriel
2012-05-13 17:43 Dan Carpenter
2012-05-14 7:07 ` Arend van Spriel
2012-05-14 8:34 ` Dan Carpenter
2012-05-14 9:06 ` Arend van Spriel
2012-05-14 9:28 ` Dan Carpenter
2012-05-14 11:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627132221.GA1114@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).