From: lemagoup@gmail.com
To: kvalo@qca.qualcomm.com
Cc: ath6kl@lists.infradead.org, linux-wireless@vger.kernel.org,
jmassot@aldebaran.com,
Pierre Le Magourou <plemagourou@aldebaran.com>
Subject: [PATCH v2 3/3] ath6kl: Unset IFF_LOWER_UP flag on AP mode leave.
Date: Mon, 4 Jul 2016 13:07:19 +0200 [thread overview]
Message-ID: <20160704110719.7694-4-plemagourou@aldebaran.com> (raw)
In-Reply-To: <20160704110719.7694-1-plemagourou@aldebaran.com>
From: Pierre Le Magourou <plemagourou@aldebaran.com>
When disabling tethering after having enabled it, the ath6kl driver does
not set the IFF_LOWER_UP flag to 0 (carrier off) on the wlan interface.
The upper layers (eg. connman) are not notified of the tethering mode
status change. So, tethering can not be activated anymore.
This patch adds a netif_carrier_off() call when stopping AP mode to fix
the problem.
Signed-off-by: Pierre Le Magourou <plemagourou@aldebaran.com>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index c9c4d7f..713d230 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -2972,6 +2972,7 @@ static int ath6kl_stop_ap(struct wiphy *wiphy, struct net_device *dev)
ath6kl_wmi_disconnect_cmd(ar->wmi, vif->fw_vif_idx);
clear_bit(CONNECTED, &vif->flags);
+ netif_carrier_off(vif->ndev);
/* Restore ht setting in firmware */
return ath6kl_restore_htcap(vif);
--
2.9.0
prev parent reply other threads:[~2016-07-04 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 11:07 [PATCH v2 0/3] ath6kl: Fix tethering problems lemagoup
2016-07-04 11:07 ` [PATCH v2 1/3] ath6kl: Fix WLAN tethering authentication problem lemagoup
2016-07-19 13:25 ` [v2,1/3] " Kalle Valo
2016-07-04 11:07 ` [PATCH v2 2/3] ath6kl: Fix wrong regulatory domain disconnection lemagoup
2016-07-04 11:07 ` lemagoup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704110719.7694-4-plemagourou@aldebaran.com \
--to=lemagoup@gmail.com \
--cc=ath6kl@lists.infradead.org \
--cc=jmassot@aldebaran.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=plemagourou@aldebaran.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox