From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Masashi Honma <masashi.honma@gmail.com>,
linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [PATCH v2] cfg80211: Add mesh peer AID setting API
Date: Wed, 6 Jul 2016 08:58:26 -0400 [thread overview]
Message-ID: <20160706125826.GA7819@localhost> (raw)
In-Reply-To: <1467808954.5460.6.camel@sipsolutions.net>
On Wed, Jul 06, 2016 at 02:42:34PM +0200, Johannes Berg wrote:
> > + * @NL80211_ATTR_MESH_PEER_AID: Association ID for the mesh peer
> > (u16). This is
> > + * used to pull the stored data for mesh peer in power save
> > state.
> >
> Why does this need new API all over?
>
> It seems to me that it could just use the regular NL80211_ATTR_STA_AID
> attribute, and the cfg80211 code would already be in place, and you'd
> just need to add a single line to mac80211 and
> to cfg80211_check_station_change() to accept that.
We are already using NL80211_ATTR_STA_AID, though -- one is for the
station's AID (in our TIM, which is NL80211_ATTR_STA_AID) and the new one
is for our AID in the peer's TIM.
There is the NL80211_ATTR_PEER_AID but that seems specific to TDLS and
also doesn't appear to be processed in the necessary way (e.g. overrides
STA_AID in nl80211_new_station).
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2016-07-06 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 9:00 [PATCH] cfg80211: Add mesh peer AID setting API Masashi Honma
2016-06-30 10:03 ` kbuild test robot
2016-06-30 11:11 ` Bob Copeland
2016-06-30 12:01 ` Masashi Honma
2016-07-01 1:19 ` [PATCH v2] " Masashi Honma
2016-07-06 12:42 ` Johannes Berg
2016-07-06 12:58 ` Bob Copeland [this message]
2016-07-06 13:03 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706125826.GA7819@localhost \
--to=me@bobcopeland.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).