Re: [PATCH 4/4 v2 iface_work] Function renaming

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5257 bytes --]

Hi,

[auto build test WARNING on mac80211/master]
[also build test WARNING on v4.7-rc7]
[cannot apply to mac80211-next/master next-20160715]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alex-Briskin/New-function-ieee80211_is_skb_handled_by_pkt_type/20160715-195540
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
config: i386-randconfig-s1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> net/mac80211/iface.c:1249:11: warning: 'struct ieee80211_sub_if_datai' declared inside parameter list will not be visible outside of this definition or declaration
       struct ieee80211_sub_if_datai *sdata)
              ^~~~~~~~~~~~~~~~~~~~~~
   net/mac80211/iface.c: In function 'mac80211_is_skb_handled_by_frame_control':
   net/mac80211/iface.c:1251:39: error: dereferencing pointer to incomplete type 'struct ieee80211_sub_if_datai'
     struct ieee80211_local *local = sdata->local;
                                          ^~
   net/mac80211/iface.c:1260:26: error: passing argument 1 of 'sta_info_get_bss' from incompatible pointer type [-Werror=incompatible-pointer-types]
      sta = sta_info_get_bss(sdata, mgmt->sa);
                             ^~~~~
   In file included from net/mac80211/ieee80211_i.h:34:0,
                    from net/mac80211/iface.c:21:
   net/mac80211/sta_info.h:644:18: note: expected 'struct ieee80211_sub_if_data *' but argument is of type 'struct ieee80211_sub_if_datai *'
    struct sta_info *sta_info_get_bss(struct ieee80211_sub_if_data *sdata,
                     ^~~~~~~~~~~~~~~~
   net/mac80211/iface.c:1272:29: error: passing argument 1 of 'ieee80211_process_delba' from incompatible pointer type [-Werror=incompatible-pointer-types]
        ieee80211_process_delba(sdata, sta, mgmt, len);
                                ^~~~~
   In file included from net/mac80211/iface.c:21:0:
   net/mac80211/ieee80211_i.h:1700:6: note: expected 'struct ieee80211_sub_if_data *' but argument is of type 'struct ieee80211_sub_if_datai *'
    void ieee80211_process_delba(struct ieee80211_sub_if_data *sdata,
         ^~~~~~~~~~~~~~~~~~~~~~~
   net/mac80211/iface.c:1284:32: error: passing argument 1 of 'ieee80211_process_mu_groups' from incompatible pointer type [-Werror=incompatible-pointer-types]
       ieee80211_process_mu_groups(sdata, mgmt);
                                   ^~~~~
   In file included from net/mac80211/iface.c:21:0:
   net/mac80211/ieee80211_i.h:1737:6: note: expected 'struct ieee80211_sub_if_data *' but argument is of type 'struct ieee80211_sub_if_datai *'
    void ieee80211_process_mu_groups(struct ieee80211_sub_if_data *sdata,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/mac80211/iface.c:1309:26: error: passing argument 1 of 'sta_info_get_bss' from incompatible pointer type [-Werror=incompatible-pointer-types]
      sta = sta_info_get_bss(sdata, mgmt->sa);
                             ^~~~~
   In file included from net/mac80211/ieee80211_i.h:34:0,
                    from net/mac80211/iface.c:21:
   net/mac80211/sta_info.h:644:18: note: expected 'struct ieee80211_sub_if_data *' but argument is of type 'struct ieee80211_sub_if_datai *'
    struct sta_info *sta_info_get_bss(struct ieee80211_sub_if_data *sdata,
                     ^~~~~~~~~~~~~~~~
   net/mac80211/iface.c: In function 'ieee80211_iface_work':
   net/mac80211/iface.c:1366:54: error: passing argument 2 of 'mac80211_is_skb_handled_by_frame_control' from incompatible pointer type [-Werror=incompatible-pointer-types]
          !mac80211_is_skb_handled_by_frame_control(skb, sdata)) {
                                                         ^~~~~
   net/mac80211/iface.c:1248:13: note: expected 'struct ieee80211_sub_if_datai *' but argument is of type 'struct ieee80211_sub_if_data *'
    static bool mac80211_is_skb_handled_by_frame_control(struct sk_buff *skb,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1249 net/mac80211/iface.c

  1233			sta = sta_info_get_bss(sdata, rx_agg->addr);
  1234			if (sta)
  1235				__ieee80211_stop_rx_ba_session(sta,
  1236							       rx_agg->tid,
  1237							       WLAN_BACK_RECIPIENT, 0,
  1238							       false);
  1239			mutex_unlock(&local->sta_mtx);
  1240			break;
  1241		default:
  1242			return false;
  1243		}
  1244		/*will return true if pkt_type found and handled */
  1245		return true;
  1246	}
  1247	
  1248	static bool mac80211_is_skb_handled_by_frame_control(struct sk_buff *skb,
> 1249				struct ieee80211_sub_if_datai *sdata)
  1250	{
  1251		struct ieee80211_local *local = sdata->local;
  1252		struct sta_info *sta;
  1253		struct ieee80211_mgmt *mgmt = (void *)skb->data;
  1254	
  1255		if (ieee80211_is_action(mgmt->frame_control) &&
  1256		    mgmt->u.action.category == WLAN_CATEGORY_BACK) {
  1257			int len = skb->len;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22543 bytes --]