From: Bob Copeland <me@bobcopeland.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iw: display 5/10 MHz channel widths
Date: Fri, 22 Jul 2016 06:38:07 -0400 [thread overview]
Message-ID: <20160722103807.GA15262@localhost> (raw)
In-Reply-To: <CAGRGNgWHJEFBnak-MCK2htkaeQcZ6dmZ=w96omC99G5Z2UJWFg@mail.gmail.com>
On Fri, Jul 22, 2016 at 07:53:35PM +1000, Julian Calaby wrote:
> Hi Bob,
Hi!
> > --- a/interface.c
> > +++ b/interface.c
> > @@ -295,6 +295,10 @@ char *channel_width_name(enum nl80211_chan_width width)
> > return "80+80 MHz";
> > case NL80211_CHAN_WIDTH_160:
> > return "160 MHz";
> > + case NL80211_CHAN_WIDTH_5:
> > + return "5 MHz";
> > + case NL80211_CHAN_WIDTH_10:
> > + return "10 MHz";
> > default:
> > return "unknown";
> > }
>
> Judging by the previous two entries, it looks like the case statements
> are sorted, so should these ones therefore be at the top of the list?
These are sorted by NL80211_CHAN_WIDTH_* attribute value, which makes
a little more sense to me than sorting by the string or numerically by
width, but sure, I can do it either way.
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2016-07-22 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 15:39 [PATCH] iw: display 5/10 MHz channel widths Bob Copeland
2016-07-22 9:53 ` Julian Calaby
2016-07-22 10:38 ` Bob Copeland [this message]
2016-07-22 11:21 ` Julian Calaby
2016-08-01 12:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722103807.GA15262@localhost \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).