Linux wireless drivers development
 help / color / mirror / Atom feed
From: Baole Ni <baolex.ni@intel.com>
To: chunkeey@googlemail.com, kvalo@codeaurora.org,
	luciano.coelho@intel.com, linuxwifi@intel.com,
	m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com,
	kyungmin.park@samsung.com, k.kozlowski@samsung.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
	baolex.ni@intel.com, a@unstable.cc, fw@strlen.de,
	Jes.Sorensen@redhat.com
Subject: [PATCH 0783/1285] Replace numeric parameter like 0444 with macro
Date: Tue,  2 Aug 2016 19:45:56 +0800	[thread overview]
Message-ID: <20160802114556.1945-1-baolex.ni@intel.com> (raw)

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/net/wireless/intersil/p54/p54spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
index 7ab2f43..07c77f8 100644
--- a/drivers/net/wireless/intersil/p54/p54spi.c
+++ b/drivers/net/wireless/intersil/p54/p54spi.c
@@ -48,11 +48,11 @@ MODULE_FIRMWARE("3826.arm");
  */
 
 static int p54spi_gpio_power = 97;
-module_param(p54spi_gpio_power, int, 0444);
+module_param(p54spi_gpio_power, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(p54spi_gpio_power, "gpio number for power line");
 
 static int p54spi_gpio_irq = 87;
-module_param(p54spi_gpio_irq, int, 0444);
+module_param(p54spi_gpio_irq, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(p54spi_gpio_irq, "gpio number for irq line");
 
 static void p54spi_spi_read(struct p54s_priv *priv, u8 address,
-- 
2.9.2


                 reply	other threads:[~2016-08-02 12:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802114556.1945-1-baolex.ni@intel.com \
    --to=baolex.ni@intel.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=a@unstable.cc \
    --cc=chuansheng.liu@intel.com \
    --cc=chunkeey@googlemail.com \
    --cc=fw@strlen.de \
    --cc=k.kozlowski@samsung.com \
    --cc=kvalo@codeaurora.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luciano.coelho@intel.com \
    --cc=m.chehab@samsung.com \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel@osciak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox