From: David Miller <davem@davemloft.net>
To: pgynther@google.com
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
joe@perches.com, akarwar@marvell.com
Subject: Re: [PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses
Date: Fri, 12 Aug 2016 20:26:13 -0700 (PDT) [thread overview]
Message-ID: <20160812.202613.197744153887748230.davem@davemloft.net> (raw)
In-Reply-To: <1471047330-8153-1-git-send-email-pgynther@google.com>
From: Petri Gynther <pgynther@google.com>
Date: Fri, 12 Aug 2016 17:15:30 -0700
> Root cause:
> mwifiex driver calls is_zero_ether_addr() against byte-aligned address:
MAC addresses really must be 16-bit aligned to be used with any of the
ethernet address manipulation and test interfaces.
Therefore this driver should do whatever it takes to avoid passing
a byte-aligned MAC address anywhere.
We _SHOULD NOT_ add support for byte aligned addresses to these
interfaces, nor add routines which by-name can handle them.
Fix this driver instead of polluting out common interfaces
unnecessarily.
Thanks.
next prev parent reply other threads:[~2016-08-13 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 0:15 [PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses Petri Gynther
2016-08-13 0:28 ` Joe Perches
2016-08-13 1:41 ` Petri Gynther
2016-08-13 2:08 ` kbuild test robot
2016-08-13 2:26 ` kbuild test robot
2016-08-13 3:26 ` David Miller [this message]
2016-08-13 3:44 ` Petri Gynther
2016-08-13 4:00 ` Joe Perches
2016-08-13 4:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812.202613.197744153887748230.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akarwar@marvell.com \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox