From: Greg KH <gregkh@linuxfoundation.org>
To: David Binderman <linuxdev.baldrick@gmail.com>
Cc: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dcb314@hotmail.com
Subject: Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?
Date: Mon, 22 Aug 2016 10:30:20 -0400 [thread overview]
Message-ID: <20160822143020.GA7695@kroah.com> (raw)
In-Reply-To: <CAMzoamY0HSt4af8EeJpt73FD++q1MZ7iHJFa4NDBtzzQrNMjbg@mail.gmail.com>
On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote:
> Hello there,
>
> linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]:
> (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always
> true
>
> Source code is
>
> if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) {
> ....
> } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
>
> Suggest remove second test.
patches are always welcome :)
next prev parent reply other threads:[~2016-08-22 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 14:07 linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ? David Binderman
2016-08-22 14:30 ` Greg KH [this message]
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl823au: hal: Remove pointless test Matthias Beyer
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl8723au: " Matthias Beyer
2016-08-31 19:32 ` [PATCH] drivers: staging: rtl823au: " Matthias Beyer
2016-09-01 15:54 ` Greg KH
2016-09-01 15:54 ` Greg KH
2016-09-04 11:01 ` [PATCH v2 0/1] " Matthias Beyer
2016-09-04 11:01 ` [PATCH v2 1/1] drivers: staging: rtl8723au: hal: " Matthias Beyer
2016-09-04 15:11 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822143020.GA7695@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dcb314@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxdev.baldrick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).