Re: [PATCH] rt2x00: add support for mac addr from device tree

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Thu, Aug 25, 2016 at 05:03:06PM +0200, Mathias Kresin wrote:
> 2016-08-25 15:19 GMT+02:00 Stanislaw Gruszka <sgruszka@redhat.com>:
> > On Thu, Aug 25, 2016 at 01:12:22PM +0200, Mathias Kresin wrote:
> >> 2016-08-25 11:33 GMT+02:00 Stanislaw Gruszka <sgruszka@redhat.com>:
> >> > On Thu, Aug 25, 2016 at 10:19:22AM +0200, Mathias Kresin wrote:
> 
> >> CPE = Customer Premises Equipment or the small plastic box from your
> >> ISP at home. The whole point of the patch is that the MAC stored in
> >> the wifi EEPROM might not be unique and need to be overridden. I'm
> >> aware of three different "home router", where each model has the same
> >> generic ralink MAC address stored in the wifi EEPROM. This can cause
> >> nasty issues.
> >
> > I think we still want MAC from EEPROM instead of random one on systems
> > without OF. Otherwise we could just use random MAC every time, but this
> > does not seems lika a good idea.
> 
> Either I got you wrong, the code does something different than I
> intended/tested or you misread the code.

I misread the patch. It's ok (except the changelog).

Thanks
Stanislaw