* [PATCH] drivers: staging: rtl8723au: hal: Remove pointless test
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl823au: hal: Remove pointless test Matthias Beyer
@ 2016-08-23 19:44 ` Matthias Beyer
2016-08-31 19:32 ` [PATCH] drivers: staging: rtl823au: " Matthias Beyer
2016-09-01 15:54 ` Greg KH
2 siblings, 0 replies; 10+ messages in thread
From: Matthias Beyer @ 2016-08-23 19:44 UTC (permalink / raw)
To: devel, gregkh, linux-kernel, linux-wireless
Cc: Jes.Sorensen, Larry.Finger, amitoj1606, bhaktipriya96, bhumirks,
ksenija.stanojevic, mail, meleodr, shivanib134
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index bfcbd7a..7f11521 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -3530,7 +3530,7 @@ bthci_CmdLinkStatusNotify(
pBtMgnt->ExtConfig.linkInfo[i].BTProfile,
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec));
pTriple += 4;
- } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
+ } else {
pBtMgnt->ExtConfig.linkInfo[i].ConnectHandle = *((u16 *)&pTriple[0]);
pBtMgnt->ExtConfig.linkInfo[i].BTProfile = pTriple[2];
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec = pTriple[3];
--
2.9.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl823au: hal: Remove pointless test Matthias Beyer
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl8723au: " Matthias Beyer
@ 2016-08-31 19:32 ` Matthias Beyer
2016-09-01 15:54 ` Greg KH
2016-09-01 15:54 ` Greg KH
2 siblings, 1 reply; 10+ messages in thread
From: Matthias Beyer @ 2016-08-31 19:32 UTC (permalink / raw)
To: devel, gregkh, linux-kernel, linux-wireless
Cc: Jes.Sorensen, Larry.Finger, amitoj1606, bhaktipriya96, bhumirks,
ksenija.stanojevic, meleodr, shivanib134
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Pinging here as nobody responded yet.
Maybe this was overlooked.
On 23-08-2016 21:44:16, Matthias Beyer wrote:
> As reported by David Binderman, this test is useless as of
>
> if (a < 3) {
> /* ... */
> } else if (a >= 3) {
> /* ... */
> }
>
> so this patch removes the second check.
>
> Matthias Beyer (1):
> drivers: staging: rtl8723au: hal: Remove pointless test
>
> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.9.2
>
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test
2016-08-31 19:32 ` [PATCH] drivers: staging: rtl823au: " Matthias Beyer
@ 2016-09-01 15:54 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2016-09-01 15:54 UTC (permalink / raw)
To: Matthias Beyer
Cc: devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
On Wed, Aug 31, 2016 at 09:32:56PM +0200, Matthias Beyer wrote:
> Pinging here as nobody responded yet.
>
> Maybe this was overlooked.
Nope, it was only a week, staging patches are at the bottom of my queue,
please give me time to get to them, I process them usually ever few
weeks...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl823au: hal: Remove pointless test Matthias Beyer
2016-08-23 19:44 ` [PATCH] drivers: staging: rtl8723au: " Matthias Beyer
2016-08-31 19:32 ` [PATCH] drivers: staging: rtl823au: " Matthias Beyer
@ 2016-09-01 15:54 ` Greg KH
2016-09-04 11:01 ` [PATCH v2 0/1] " Matthias Beyer
2 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2016-09-01 15:54 UTC (permalink / raw)
To: Matthias Beyer
Cc: devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
On Tue, Aug 23, 2016 at 09:44:16PM +0200, Matthias Beyer wrote:
> As reported by David Binderman, this test is useless as of
>
> if (a < 3) {
> /* ... */
> } else if (a >= 3) {
> /* ... */
> }
>
> so this patch removes the second check.
>
> Matthias Beyer (1):
> drivers: staging: rtl8723au: hal: Remove pointless test
>
> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
There is no patch here :(
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2 0/1] Remove pointless test
2016-09-01 15:54 ` Greg KH
@ 2016-09-04 11:01 ` Matthias Beyer
2016-09-04 11:01 ` [PATCH v2 1/1] drivers: staging: rtl8723au: hal: " Matthias Beyer
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Beyer @ 2016-09-04 11:01 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
Re-sending as
On 01-09-2016 17:54:47, Greg KH wrote:
> There is no patch here :(
----8<----
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matthias Beyer (1):
drivers: staging: rtl8723au: hal: Remove pointless test
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.3
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test
2016-09-04 11:01 ` [PATCH v2 0/1] " Matthias Beyer
@ 2016-09-04 11:01 ` Matthias Beyer
2016-09-04 15:11 ` Sudip Mukherjee
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Beyer @ 2016-09-04 11:01 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index 6989580..47e8d69 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -3530,7 +3530,7 @@ bthci_CmdLinkStatusNotify(
pBtMgnt->ExtConfig.linkInfo[i].BTProfile,
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec));
pTriple += 4;
- } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
+ } else {
pBtMgnt->ExtConfig.linkInfo[i].ConnectHandle = *((u16 *)&pTriple[0]);
pBtMgnt->ExtConfig.linkInfo[i].BTProfile = pTriple[2];
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec = pTriple[3];
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test
2016-09-04 11:01 ` [PATCH v2 1/1] drivers: staging: rtl8723au: hal: " Matthias Beyer
@ 2016-09-04 15:11 ` Sudip Mukherjee
0 siblings, 0 replies; 10+ messages in thread
From: Sudip Mukherjee @ 2016-09-04 15:11 UTC (permalink / raw)
To: Matthias Beyer
Cc: gregkh, devel, meleodr, ksenija.stanojevic, Jes.Sorensen,
linux-wireless, linux-kernel, shivanib134, bhaktipriya96,
bhumirks, Larry.Finger
On Sun, Sep 04, 2016 at 01:01:20PM +0200, Matthias Beyer wrote:
> This patch removes the pointless `else if` test.
>
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
> Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
> ---
looks like Greg has already applied your first patch.
db0c12744f8d ("drivers: staging: rtl8723au: hal: Remove pointless test")
regards
sudip
^ permalink raw reply [flat|nested] 10+ messages in thread