From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"Brett Rudley" <brudley@broadcom.com>,
"Arend van Spriel" <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Hante Meuleman" <meuleman@broadcom.com>,
brcm80211-dev-list@broadcom.com,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [FIX?] brcmfmac: fix possible overflows in flowrings code by bumping u8 to u16
Date: Sat, 3 Sep 2016 14:06:48 +0000 (UTC) [thread overview]
Message-ID: <20160903140648.0205762169@smtp.codeaurora.org> (raw)
In-Reply-To: <1454198830-13971-1-git-send-email-zajec5@gmail.com>
Rafał Miłecki wrote:
> Some devices may use more than 255 flowings, below is log from BCM4366:
> [ 194.606245] brcmfmac: brcmf_pcie_init_ringbuffers Nr of flowrings is 264
>
> At various places we were using u8 which could lead to storing wrong
> number or infinite loops when indexing incorrectly. Initially this
> issue was spotted as infinite loop in brcmf_flowring_detach.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
There has been no activity on this patch so I'll drop this. Please resend if
this is still needed.
--
Sent by pwcli
https://patchwork.kernel.org/patch/8172531/
prev parent reply other threads:[~2016-09-03 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 0:07 [PATCH FIX?] brcmfmac: fix possible overflows in flowrings code by bumping u8 to u16 Rafał Miłecki
2016-01-31 9:56 ` Arend van Spriel
2016-01-31 10:12 ` Arend van Spriel
2016-01-31 11:43 ` Rafał Miłecki
2016-02-01 8:46 ` Hante Meuleman
2016-02-01 9:43 ` Arend van Spriel
2016-09-03 14:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903140648.0205762169@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).