From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Felix Fietkau" <nbd@nbd.name>,
linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [PATCH] mac80211: fix sequence number allocation regression
Date: Wed, 12 Oct 2016 08:37:10 -0400 [thread overview]
Message-ID: <20161012123710.GE18919@localhost> (raw)
In-Reply-To: <1476254985.5271.1.camel@sipsolutions.net>
On Wed, Oct 12, 2016 at 08:49:45AM +0200, Johannes Berg wrote:
> On Tue, 2016-10-11 at 11:28 +0200, Felix Fietkau wrote:
> > The recent commit that moved around TX handlers dropped the sequence
> > number allocation at the end of ieee80211_tx_dequeue and calls
> > ieee80211_tx_h_sequence instead (for the non-fast-xmit case).
> > However, it did not change the fast-xmit sequence allocation
> > condition
> > in ieee80211_xmit_fast_finish, which skipped seqno alloc if
> > intermediate
> > tx queues are being used.
> >
> > Drop the now obsolete condition.
>
> Hm. I don't know what tree you're looking at, but it looks like I *did*
> in fact resolve this correctly; the (now) erroneous condition doesn't
> exist in mac80211 nor in mac80211-next (nor net, net-next, linux).
>
> It does seem to exist in wireless-testing, but that's not something I
> can control.
Sorry about that, I should've rechecked this after Johannes did the merge.
I applied this patch (to wireless-testing) and pushed tag wt-2016-10-12.
Let me know of any further issues.
As a check I also diffed against mac80211-next/master and found additional
merge damage in the diff which I fixed up. Once the merge window closes
in a few days, I'll resync to the masters of all the trees.
--
Bob Copeland %% http://bobcopeland.com/
prev parent reply other threads:[~2016-10-12 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 9:28 [PATCH] mac80211: fix sequence number allocation regression Felix Fietkau
2016-10-11 9:39 ` Toke Høiland-Jørgensen
2016-10-12 6:49 ` Johannes Berg
2016-10-12 12:37 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012123710.GE18919@localhost \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).