From: Thomas Graf <tgraf@suug.ch>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: davem@davemloft.net, daniel@iogearbox.net,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr
Date: Wed, 26 Oct 2016 11:52:38 +0200 [thread overview]
Message-ID: <20161026095238.GB16590@pox.localdomain> (raw)
In-Reply-To: <1477472376.4059.23.camel@sipsolutions.net>
On 10/26/16 at 10:59am, Johannes Berg wrote:
>
> > /**
> > + * nla_memdup - duplicate attribute memory (kmemdup)
> > + * @src: netlink attribute to duplicate from
> > + * @gfp: GFP mask
>
> Actually, is there any point in passing a GFP mask? None of the current
> users need it, and it seems fairly unlikely to be needed since this is
> typically used on the netlink input path, where you surely shouldn't
> need GFP_ATOMIC or so?
I'm fine either way. I didn't want to make assumptions which need
later changes. It's not hurting either and the function prototype
is very small.
next prev parent reply other threads:[~2016-10-26 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 8:53 [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr Thomas Graf
2016-10-26 8:56 ` Johannes Berg
2016-10-26 8:57 ` Daniel Borkmann
2016-10-26 8:59 ` Johannes Berg
2016-10-26 9:52 ` Thomas Graf [this message]
2016-10-26 10:18 ` Johannes Berg
2016-10-29 18:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026095238.GB16590@pox.localdomain \
--to=tgraf@suug.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox