From: Brian Norris <briannorris@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Xinming Hu <huxm@marvell.com>,
Amitkumar Karwar <akarwar@marvell.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Cathy Luo <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
"rajatja@google.com" <rajatja@google.com>
Subject: Re: [PATCH v2 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv
Date: Thu, 3 Nov 2016 11:27:05 -0700 [thread overview]
Message-ID: <20161103182705.GA1153@google.com> (raw)
In-Reply-To: <20161103161504.GA15366@dtor-ws>
On Thu, Nov 03, 2016 at 09:15:04AM -0700, Dmitry Torokhov wrote:
> On Thu, Nov 03, 2016 at 08:34:06AM +0000, Xinming Hu wrote:
> > > -----Original Message-----
> > > From: linux-wireless-owner@vger.kernel.org
> > > [mailto:linux-wireless-owner@vger.kernel.org] On Behalf Of Dmitry Torokhov
> > >
> > > Instead please remove call to mwifiex_shutdown_drv() in the main routine
> > > and "if (adapter->mwifiex_processing)" check here.
> > >
> >
> > mwifiex_main_process will be used from interrupt or workqueue.
> > Now we have disabled interrupt and flush workqueue, so
> > mwifiex_main_process won't be scheduled in the future.
> > But mwifiex_main_process might just running in context of last
> > interrupt, so we need wait current main_process complete in
> > mwifiex_shutdown_drv.
>
> synchronize_irq() is your friend then.
Hmm, that sounds right, but IIUC, the "interrupt context" is actually
only used for SDIO, and for SDIO, the driver doesn't actually have
access to the IRQ number. The MMC/SDIO layer has some extra abstraction
around the IRQ. So this may be more difficult than it appears.
Do we need a sdio_synchronize_irq() API?
Brian
next prev parent reply other threads:[~2016-11-03 18:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 9:12 [PATCH v2 1/5] mwifiex: remove redundant condition in main process Amitkumar Karwar
2016-10-27 9:12 ` [PATCH v2 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv Amitkumar Karwar
2016-10-27 17:44 ` Dmitry Torokhov
2016-11-03 8:34 ` Xinming Hu
2016-11-03 16:15 ` Dmitry Torokhov
2016-11-03 18:27 ` Brian Norris [this message]
2016-11-03 18:48 ` Dmitry Torokhov
2016-11-04 3:02 ` Xinming Hu
2016-10-27 9:12 ` [PATCH v2 3/5] mwifiex: do not free firmware dump memory " Amitkumar Karwar
2016-10-27 9:12 ` [PATCH v2 4/5] mwifiex: get rid of drv_info* adapter variables Amitkumar Karwar
2016-10-27 9:12 ` [PATCH v2 5/5] mwifiex: wait firmware dump complete during card remove process Amitkumar Karwar
2016-10-27 18:48 ` Brian Norris
2016-11-16 15:27 ` Amitkumar Karwar
2016-10-27 18:35 ` [PATCH v2 1/5] mwifiex: remove redundant condition in main process Brian Norris
2016-11-03 8:04 ` Xinming Hu
2016-11-07 18:46 ` Kalle Valo
2016-11-10 19:46 ` Brian Norris
2016-11-16 13:08 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103182705.GA1153@google.com \
--to=briannorris@chromium.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).