From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
Date: Fri, 18 Nov 2016 10:35:41 -0800 [thread overview]
Message-ID: <20161118183541.GI28340@tuxbot> (raw)
In-Reply-To: <a4095c49fe5a42c4a405b1faf6c0f3b7@euamsexm01a.eu.qualcomm.com>
On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:
> Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> > The correct include file for getting errno constants and ERR_PTR() is
> > linux/err.h, rather than linux/errno.h, so fix the include.
> >
> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state")
> > Acked-by: Andy Gross <andy.gross@linaro.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> For some reason this fails to compile now. Can you take a look, please?
>
> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> 5 patches set to Changes Requested.
>
> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client
This patch was updated with the necessary depends in Kconfig to catch
this exact issue and when I pull in your .config (which has QCOM_SMD=n,
QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine.
I've tested the various combinations and it seems to work fine. Do you
have any other patches in your tree? Any stale objects?
Would you mind retesting this, before I invest more time in trying to
reproduce the issue you're seeing?
Regards,
Bjorn
next prev parent reply other threads:[~2016-11-18 18:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 6:06 [PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 2/5] wcn36xx: Transition driver to SMD client Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 3/5] wcn36xx: Implement firmware assisted scan Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 4/5] wcn36xx: Implement print_reg indication Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex Bjorn Andersson
2016-11-16 18:49 ` [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Kalle Valo
2016-11-16 18:54 ` Valo, Kalle
2016-11-18 18:35 ` Bjorn Andersson [this message]
2016-11-22 14:55 ` Valo, Kalle
2016-11-30 18:40 ` Valo, Kalle
2016-12-01 5:13 ` Valo, Kalle
2016-12-01 10:17 ` Valo, Kalle
2016-12-01 14:21 ` Andy Gross
2016-12-05 11:45 ` Valo, Kalle
2017-01-12 10:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118183541.GI28340@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).