From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, Ping-Ke Shih <pkshih@realtek.com>,
linux-wireless@vger.kernel.org, kvalo@codeaurora.org
Subject: Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE
Date: Tue, 6 Dec 2016 00:48:23 +0300 [thread overview]
Message-ID: <20161205214823.GK8176@mwanda> (raw)
In-Reply-To: <e4d07a23-d4d6-7ebd-7acd-69de3218a685@lwfinger.net>
On Mon, Dec 05, 2016 at 11:17:28AM -0600, Larry Finger wrote:
> On 12/05/2016 05:38 AM, Dan Carpenter wrote:
> >On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote:
> >>From: Ping-Ke Shih <pkshih@realtek.com>
> >>
> >>The btcoexist routines for the RTL8192EE have been extensively rewritten.
> >>
> >
> >This patch does a million things and is totally unreviewable. The
> >patch description doesn't say what patch does or why. It's 5k lines
> >of diff. What the heck???
>
> I am caught in a bind. The BT coexistence routines are written by a
> Realtek contractor. As I cannot get the individual patches from
> Realtek, there is no chance of getting them from a 3rd party.
These patches are absolutely impenetrable. A few years ago in SCSI we
gave a vendor a one time pass to just merge a huge patch and sync with
mainline. We could view this in the same light, except that I think
when we moved this driver out of staging that was the one time pass. By
now they should be proper kernel devs who can wipe their own bottoms...
We maybe should merge this and move the driver back to staging until
they can figure out how to maintain stuff? That's a serious suggestion.
This patch is no way close to minimum quality requirements for upstream.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-05 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 17:32 [PATCH 0/7] rtlwifi: btcoexist: Rewrite BT coexistence routines Larry Finger
2016-12-03 17:32 ` [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE Larry Finger
2016-12-05 11:38 ` Dan Carpenter
2016-12-05 17:17 ` Larry Finger
2016-12-05 21:48 ` Dan Carpenter [this message]
2016-12-30 13:12 ` [1/7] " Kalle Valo
2016-12-03 17:32 ` [PATCH 2/7] rtlwifi: btcoexist: Rewrite halbtc8723b1ant code Larry Finger
2016-12-03 17:32 ` [PATCH 3/7] rtlwifi: btcoexist: Rewrite of halbtc8723b2ant Larry Finger
2016-12-03 17:32 ` [PATCH 4/7] rtlwifi: btcoexist: Rewrite routine halbtc8821a1ant Larry Finger
2016-12-03 17:32 ` [PATCH 5/7] rtlwifi: btcoexist: Rewrite routine halbtc8821a2ant Larry Finger
2016-12-03 17:32 ` [PATCH 6/7] rtlwifi: Add btcoex record_pwr_mode Larry Finger
2016-12-03 17:32 ` [PATCH 7/7] rtlwifi: btcoexist control to enter/leave LPS Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205214823.GK8176@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).