From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Rahul Krishnan <mrahul.krishnan@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool
Date: Fri, 6 Jan 2017 23:46:26 +0100 [thread overview]
Message-ID: <20170106234626.24f5f6ad@wiggum> (raw)
In-Reply-To: <CACna6ryhvkSaHgU9igshnMjNg=wgeXd3p57VXxbr0ykoEtLH_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
> > @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm)
> > default:
> > SSB_WARN_ON(1);
> > }
> > - size = (1 << (size + 1));
> > -
> > - return size;
> > + return (1 << (size + 1));
> > }
> > EXPORT_SYMBOL(ssb_admatch_size);
I'm all for cleaning up code, but I don't really see how this
change improves the code.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-06 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 15:20 [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
2017-01-06 22:39 ` Rafał Miłecki
2017-01-06 22:40 ` Rafał Miłecki
2017-01-06 22:46 ` Michael Büsch [this message]
2017-01-07 0:52 ` Julian Calaby
2017-01-07 13:39 ` kbuild test robot
2017-01-07 13:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106234626.24f5f6ad@wiggum \
--to=m@bues.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mrahul.krishnan@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).