From: Kalle Valo <kvalo@codeaurora.org>
To: Vincent <vincent.stehle@laposte.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
"Vincent Stehlé" <vincent.stehle@laposte.net>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Joe Perches" <joe@perches.com>,
"Ping-Ke Shih" <pkshih@realtek.com>
Subject: Re: [next] rtlwifi: rtl8192de: fix missing curly braces
Date: Thu, 12 Jan 2017 15:11:04 +0000 (UTC) [thread overview]
Message-ID: <20170112151105.0D38F613D3@smtp.codeaurora.org> (raw)
In-Reply-To: <20170110095521.4410-1-vincent.stehle@laposte.net>
Vincent <vincent.stehle@laposte.net> wrote:
> Restore some curly braces that have been removed in commit c93ac39da006457f
> ("rtlwifi: Remove some redundant code") while removing redundant messages
> and extraneous braces.
>
> This fixes the following smatch warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:326 rtl92d_download_fw() warn: curly braces intended?
>
> ...and the following coccinelle warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:325:2-38: code aligned with following code on line 326
>
> Fixes: c93ac39da006457f ("rtlwifi: Remove some redundant code")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Joe Perches <joe@perches.com>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
Larry also sent a fix:
rtlwifi: rtl8192de: Remove a pointless goto
https://patchwork.kernel.org/patch/9508121/
Patch set to Superseded.
--
https://patchwork.kernel.org/patch/9506837/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-01-12 15:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 18:22 [PATCH 00/14 V2] rtlwifi: Start reworking of debug system Larry Finger
2016-12-15 18:22 ` [PATCH 01/14 V2] rtlwifi: Replace local debug macro RT_ASSERT Larry Finger
2016-12-30 13:55 ` [01/14,V2] " Kalle Valo
2016-12-15 18:22 ` [PATCH 02/14 V2] rtlwifi: Remove RT_TRACE messages that use DBG_EMERG Larry Finger
2016-12-16 19:31 ` Joe Perches
2016-12-15 18:22 ` [PATCH 03/14 V2] rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG Larry Finger
2016-12-16 19:34 ` Joe Perches
2016-12-15 18:23 ` [PATCH 04/14 V2] rtlwifi: rtl8723be: " Larry Finger
2016-12-15 18:23 ` [PATCH 05/14 V2] rtlwifi: rtl8723ae: " Larry Finger
2016-12-15 18:23 ` [PATCH 06/14 V2] rtlwifi: rtl8192ee: " Larry Finger
2016-12-15 18:23 ` [PATCH 07/14 V2] rtlwifi: rtl8723-common: " Larry Finger
2016-12-15 18:23 ` [PATCH 08/14] rtlwifi: rtl8192se: " Larry Finger
2016-12-15 18:23 ` [PATCH 09/14 V2] rtlwifi: rtl8192de: " Larry Finger
2016-12-15 18:23 ` [PATCH 10/14 V2] rtlwifi: rtl8192cu: " Larry Finger
2016-12-15 18:23 ` [PATCH 11/14 V2] rtlwifi: rtl8192ce: " Larry Finger
2016-12-15 18:23 ` [PATCH 12/14 V2] rtlwifi: rtl8192c-common: " Larry Finger
2016-12-15 18:23 ` [PATCH 13/14 V2] rtlwifi: rtl8188ee: " Larry Finger
2016-12-15 18:23 ` [PATCH 14/14 V2] rtlwifi: Remove some redundant code Larry Finger
2016-12-30 13:53 ` Kalle Valo
2017-01-10 9:55 ` [PATCH next] rtlwifi: rtl8192de: fix missing curly braces Vincent Stehlé
2017-01-12 15:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112151105.0D38F613D3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).