From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-wireless@vger.kernel.org, lede-dev@lists.infradead.org,
openwrt-devel@lists.openwrt.org, john@phrozen.org, nbd@nbd.name,
roman@advem.lv, evaxige@qq.com, c.mignanti@gmail.com,
michel.stempin@wanadoo.fr, vasilugin@yandex.ru,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org
Date: Fri, 13 Jan 2017 15:15:55 +0100 [thread overview]
Message-ID: <20170113141554.GA8018@redhat.com> (raw)
In-Reply-To: <20170113035020.GA9063@makrotopia.org>
Hi
On Fri, Jan 13, 2017 at 04:50:32AM +0100, Daniel Golle wrote:
> Please review and comment, so we can get those patches merged!
As already pointed by Kalle posting patches to mailing list is better
way for review. Posing patches is easy with git-format-patch and
git-send-email. Ideally patch series should not be long, let say no more
than 30 patches - I suggest to split this into two series: second one
for RT3853 support and first one for other patches.
> evaxige (1):
> rt2x00: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit
I think I would prefer to remove:
WARN_ON_ONCE(bcn_num != rt2x00dev->intf_beaconing);
line instead of this patch. Other patches looks ok after quick glance.
I think you can post them as normal PATCH in the topic (not as RFC).
Thanks
Stanislaw
next prev parent reply other threads:[~2017-01-13 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 3:50 [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org Daniel Golle
2017-01-13 10:46 ` Kalle Valo
2017-01-13 15:46 ` Daniel Golle
2017-01-13 15:59 ` Johannes Berg
2017-01-13 16:17 ` Daniel Golle
2017-01-13 22:17 ` [OpenWrt-Devel] " Daniel Golle
2017-01-13 21:22 ` Christian Lamparter
2017-01-13 14:15 ` Stanislaw Gruszka [this message]
2017-01-14 16:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113141554.GA8018@redhat.com \
--to=sgruszka@redhat.com \
--cc=c.mignanti@gmail.com \
--cc=daniel@makrotopia.org \
--cc=evaxige@qq.com \
--cc=helmut.schaa@googlemail.com \
--cc=john@phrozen.org \
--cc=lede-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michel.stempin@wanadoo.fr \
--cc=nbd@nbd.name \
--cc=openwrt-devel@lists.openwrt.org \
--cc=roman@advem.lv \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).