From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
<linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org, Cathy Luo <cluo@marvell.com>,
Brian Norris <briannorris@chromium.org>
Subject: Re: mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print
Date: Tue, 17 Jan 2017 12:03:50 +0000 (UTC) [thread overview]
Message-ID: <20170117120350.5CE4E607CE@smtp.codeaurora.org> (raw)
In-Reply-To: <20170109233350.134036-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> Similar to commit fcd2042e8d36 ("mwifiex: printk() overflow with 32-byte
> SSIDs"), we failed to account for the existence of 32-char SSIDs in our
> debugfs code. Unlike in that case though, we zeroed out the containing
> struct first, and I'm pretty sure we're guaranteed to have some padding
> after the 'ssid.ssid' and 'ssid.ssid_len' fields (the struct is 33 bytes
> long).
>
> So, this is the difference between:
>
> # cat /sys/kernel/debug/mwifiex/mlan0/info
> ...
> essid="0123456789abcdef0123456789abcdef "
> ...
>
> and the correct output:
>
> # cat /sys/kernel/debug/mwifiex/mlan0/info
> ...
> essid="0123456789abcdef0123456789abcdef"
> ...
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
6183468a23fc mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print
--
https://patchwork.kernel.org/patch/9506069/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-01-17 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 23:33 [PATCH] mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print Brian Norris
2017-01-17 12:03 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117120350.5CE4E607CE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).