From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [v2, 1/3] rtlwifi: Download firmware as bytes rather than as dwords
Date: Fri, 20 Jan 2017 10:06:48 +0000 (UTC) [thread overview]
Message-ID: <20170120100648.A7F5F609FD@smtp.codeaurora.org> (raw)
In-Reply-To: <20170119202808.27752-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> The firmware is read from disk as a little-endian byte string. The code
> that loads the firmware into the device transfers it as 4-byte quantities.
> The routines that write multi-byte quantities on BE hardware assume that
> the data are in CPU order, and automatically do the conversion to the LE
> order required by the device. As a result, the firmware is transmitted
> incorrectly. Rather than do multiple byte swaps on the data, the download
> routine is revised to transmit bytes rather than dwords. Although the
> number of I/O operations is increased, the firmware is not often loaded.
>
> All drivers have the same bug, and use essentially the same code to
> download firmware. These routines have been moved into rtlwifi.
>
> Some CamelCase variables have been renamed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
3 patches applied to wireless-drivers-next.git, thanks.
89d32c9071aa rtlwifi: Download firmware as bytes rather than as dwords
69d8597e9fe5 rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE
106e0deca1ac rtlwifi: rtl8192cu: Convert driver to use common macros
--
https://patchwork.kernel.org/patch/9526749/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-01-20 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 20:28 [PATCH 0/3 v2] rtlwifi: Patches for proper operation on big-endian hardware Larry Finger
2017-01-19 20:28 ` [PATCH v2 1/3] rtlwifi: Download firmware as bytes rather than as dwords Larry Finger
2017-01-20 10:06 ` Kalle Valo [this message]
2017-01-19 20:28 ` [PATCH v2 2/3] rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE Larry Finger
2017-01-19 20:28 ` [PATCH v2 3/3] rtlwifi: rtl8192cu: Convert driver to use common macros Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120100648.A7F5F609FD@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).