From: "Rafał Miłecki" <zajec5@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
"Franky Lin" <frankyl@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH 3/6] brcmfmac: pcie: store private pointer to struct brcmf_pub
Date: Tue, 24 Jan 2017 16:06:09 +0100 [thread overview]
Message-ID: <20170124150612.25138-3-zajec5@gmail.com> (raw)
In-Reply-To: <20170124150612.25138-1-zajec5@gmail.com>
From: Rafał Miłecki <rafal@milecki.pl>
Getting this pointer in PCIe code is not trivial and requires using
dev_get_drvdata helper which adds extra line of code. Having access to
this struct is useful for using generic stuff and e.g. improving logging
messages.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 19db8f26729a..a6e7f670d893 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -265,6 +265,7 @@ struct brcmf_pciedev_info {
void (*write_ptr)(struct brcmf_pciedev_info *devinfo, u32 mem_offset,
u16 value);
struct brcmf_mp_device *settings;
+ struct brcmf_pub *pub;
};
struct brcmf_pcie_ringbuf {
@@ -1565,14 +1566,18 @@ static void brcmf_pcie_release_resource(struct brcmf_pciedev_info *devinfo)
static int brcmf_pcie_attach_bus(struct brcmf_pciedev_info *devinfo)
{
+ struct device *dev = &devinfo->pdev->dev;
+ struct brcmf_bus *bus = dev_get_drvdata(dev);
int ret;
/* Attach to the common driver interface */
- ret = brcmf_attach(&devinfo->pdev->dev, devinfo->settings);
+ ret = brcmf_attach(dev, devinfo->settings);
if (ret) {
brcmf_err("brcmf_attach failed\n");
} else {
- ret = brcmf_bus_started(&devinfo->pdev->dev);
+ devinfo->pub = bus->drvr;
+
+ ret = brcmf_bus_started(dev);
if (ret)
brcmf_err("dongle is not responding\n");
}
--
2.11.0
next prev parent reply other threads:[~2017-01-24 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:06 [PATCH 1/6] brcmfmac: switch to C function (__brcmf_err) for printing errors Rafał Miłecki
2017-01-24 15:06 ` [PATCH 2/6] brcmfmac: add struct brcmf_pub parameter to the __brcmf_err Rafał Miłecki
2017-01-24 23:41 ` kbuild test robot
2017-01-24 15:06 ` Rafał Miłecki [this message]
2017-01-24 15:06 ` [PATCH 4/6] brcmfmac: usb: store private pointer to struct brcmf_pub Rafał Miłecki
2017-01-24 15:06 ` [PATCH 5/6] brcmfmac: modify all brcmf_err calls adding " Rafał Miłecki
2017-01-24 22:02 ` kbuild test robot
2017-01-24 22:08 ` Rafał Miłecki
2017-01-24 23:55 ` kbuild test robot
2017-01-24 15:06 ` [PATCH 6/6] brcmfmac: use dev_err to print errors Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124150612.25138-3-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).