* [PATCH] wlcore: print the sdio buffer after reading it
@ 2017-01-26 15:35 Guy Mishol
2017-01-28 7:11 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Guy Mishol @ 2017-01-26 15:35 UTC (permalink / raw)
To: linux-wireless; +Cc: Guy Mishol
fix an issue where we printed the sdio buffer before
actually read it.
Signed-off-by: Guy Mishol <guym@ti.com>
---
drivers/net/wireless/ti/wlcore/sdio.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 47fe7f9..287023e 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -81,13 +81,6 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,
sdio_claim_host(func);
- if (unlikely(dump)) {
- printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
- print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
- DUMP_PREFIX_OFFSET, 16, 1,
- buf, len, false);
- }
-
if (unlikely(addr == HW_ACCESS_ELP_CTRL_REG)) {
((u8 *)buf)[0] = sdio_f0_readb(func, addr, &ret);
dev_dbg(child->parent, "sdio read 52 addr 0x%x, byte 0x%02x\n",
@@ -107,6 +100,13 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,
if (WARN_ON(ret))
dev_err(child->parent, "sdio read failed (%d)\n", ret);
+ if (unlikely(dump)) {
+ printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
+ print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
+ DUMP_PREFIX_OFFSET, 16, 1,
+ buf, len, false);
+ }
+
return ret;
}
--
2.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: wlcore: print the sdio buffer after reading it
2017-01-26 15:35 [PATCH] wlcore: print the sdio buffer after reading it Guy Mishol
@ 2017-01-28 7:11 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-01-28 7:11 UTC (permalink / raw)
To: Guy Mishol; +Cc: linux-wireless, Guy Mishol
Guy Mishol <guym@ti.com> wrote:
> fix an issue where we printed the sdio buffer before
> actually read it.
>
> Signed-off-by: Guy Mishol <guym@ti.com>
Patch applied to wireless-drivers-next.git, thanks.
64ad08605e84 wlcore: print the sdio buffer after reading it
--
https://patchwork.kernel.org/patch/9539423/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-28 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 15:35 [PATCH] wlcore: print the sdio buffer after reading it Guy Mishol
2017-01-28 7:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).