From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
Helmut Schaa <helmut.schaa@googlemail.com>,
Daniel Golle <daniel@makrotopia.org>,
Gabor Juhos <juhosg@openwrt.org>,
Serge Vasilugin <vasilugin@yandex.ru>,
Mathias Kresin <dev@kresin.me>,
Michel Stempin <michel.stempin@wanadoo.fr>
Subject: Re: [PATCH v4 1/3] rt2x00: add copy of clk for soc devices
Date: Sun, 29 Jan 2017 12:16:27 +0100 [thread overview]
Message-ID: <20170129111626.GA7489@redhat.com> (raw)
In-Reply-To: <52ba40db-0f58-e982-2fd0-31d62343203d@nbd.name>
On Sat, Jan 28, 2017 at 08:39:15PM +0100, Felix Fietkau wrote:
> > rt2x00dev->hw = hw;
> > rt2x00dev->irq = platform_get_irq(pdev, 0);
> > rt2x00dev->name = pdev->dev.driver->name;
> > + rt2x00dev->clk = clk_get(&pdev->dev);
> This looks broken, clk_get takes two parameters, not just one.
Err, since patch was already applied in -next, I will post fix
in separate patch.
Thanks
Stanislaw
next prev parent reply other threads:[~2017-01-29 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 13:28 [PATCH v4 0/3] rt2x00: RT5350 support Stanislaw Gruszka
2017-01-20 13:28 ` [PATCH v4 1/3] rt2x00: add copy of clk for soc devices Stanislaw Gruszka
2017-01-20 14:13 ` Daniel Golle
2017-01-28 7:09 ` [v4,1/3] " Kalle Valo
2017-01-28 19:39 ` [PATCH v4 1/3] " Felix Fietkau
2017-01-29 11:16 ` Stanislaw Gruszka [this message]
2017-01-20 13:28 ` [PATCH v4 2/3] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal Stanislaw Gruszka
2017-01-20 13:28 ` [PATCH v4 3/3] rt2x00: add support for RT5350 WiSoC Stanislaw Gruszka
2017-01-20 14:32 ` [PATCH v4 0/3] rt2x00: RT5350 support Daniel Golle
2017-01-20 15:38 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129111626.GA7489@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michel.stempin@wanadoo.fr \
--cc=nbd@nbd.name \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).