From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
sgruszka@redhat.com, johannes.berg@intel.com
Subject: Re: [PATCH] average: change to declare precision, not factor
Date: Wed, 15 Feb 2017 12:54:03 -0500 (EST) [thread overview]
Message-ID: <20170215.125403.419777696065228170.davem@davemloft.net> (raw)
In-Reply-To: <20170215084926.29482-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 15 Feb 2017 09:49:26 +0100
> From: Johannes Berg <johannes.berg@intel.com>
>
> Declaring the factor is counter-intuitive, and people are prone
> to using small(-ish) values even when that makes no sense.
>
> Change the DECLARE_EWMA() macro to take the fractional precision,
> in bits, rather than a factor, and update all users.
>
> While at it, add some more documentation.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> Unless I hear any objections, I will take this through my tree.
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2017-02-15 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 8:49 [PATCH] average: change to declare precision, not factor Johannes Berg
2017-02-15 17:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215.125403.419777696065228170.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a@unstable.cc \
--cc=jasowang@redhat.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=sw@simonwunderlich.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox