From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46708 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdBOJQZ (ORCPT ); Wed, 15 Feb 2017 04:16:25 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: rt2500usb: don't mark register accesses as inline From: Kalle Valo In-Reply-To: <20170214212846.2809141-1-arnd@arndb.de> References: <20170214212846.2809141-1-arnd@arndb.de> To: Arnd Bergmann Cc: Stanislaw Gruszka , Helmut Schaa , Arnd Bergmann , Mathias Kresin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20170215091624.6F1AB608EA@smtp.codeaurora.org> (sfid-20170215_101710_787190_A922E2D5) Date: Wed, 15 Feb 2017 09:16:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann wrote: > When CONFIG_KASAN is set, we get a rather large stack here: > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function 'rt2500usb_set_device_state': > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size of 3032 bytes is larger than 100 bytes [-Werror=frame-larger-than=] > > If we don't force those functions to be inline, the compiler can figure this > out better itself and not inline the functions when doing so would be harmful, > reducing the stack size to a merge 256 bytes. > > Note that there is another problem that manifests in this driver, as a result > of the typecheck() macro causing even larger stack frames. > > Signed-off-by: Arnd Bergmann Patch applied to wireless-drivers-next.git, thanks. 727241660912 rt2500usb: don't mark register accesses as inline -- https://patchwork.kernel.org/patch/9572947/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches