From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from vmicros1.altlinux.org ([194.107.17.57]:52184 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdBTV2R (ORCPT ); Mon, 20 Feb 2017 16:28:17 -0500 Date: Tue, 21 Feb 2017 00:28:14 +0300 From: "Dmitry V. Levin" To: Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: linux-wireless@vger.kernel.org, x86@kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] uapi: fix definition of struct sockaddr_nfc_llcp on x32 and mips n32 Message-ID: <20170220212814.GA13795@altlinux.org> (sfid-20170220_222845_777361_889110FF) References: <20170220181533.GA11185@altlinux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170220181533.GA11185@altlinux.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Feb 20, 2017 at 09:15:33PM +0300, Dmitry V. Levin wrote: > Replace size_t with __kernel_size_t to fix definition of struct > sockaddr_nfc_llcp on architectures like x32 and mips n32 where > sizeof(size_t) < sizeof(__kernel_size_t). > > This also fixes the following linux/nfc.h userspace compilation error: > > /usr/include/linux/nfc.h:279:2: error: unknown type name 'size_t' > size_t service_name_len; > > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry V. Levin > --- > include/uapi/linux/nfc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/nfc.h b/include/uapi/linux/nfc.h > index 399f39f..f8ccc12 100644 > --- a/include/uapi/linux/nfc.h > +++ b/include/uapi/linux/nfc.h > @@ -276,7 +276,7 @@ struct sockaddr_nfc_llcp { > __u8 dsap; /* Destination SAP, if known */ > __u8 ssap; /* Source SAP to be bound to */ > char service_name[NFC_LLCP_MAX_SERVICE_NAME]; /* Service name URI */; > - size_t service_name_len; > + __kernel_size_t service_name_len; > }; > > /* NFC socket protocols */ Unfortunately, this is not the right fix for the problem. It was definitely a bad idea to use architecture dependent types in the definition of struct sockaddr_nfc_llcp. Somebody will have to implement a compat layer to make it work properly with x86, x32, and other compat personalities. -- ldv