From: Kalle Valo <kvalo@codeaurora.org>
To: Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com>
Cc: linux-wireless@vger.kernel.org, kvalo@qca.qualcomm.com,
jouni@qca.qualcomm.com,
Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com>
Subject: Re: [v4] ath10k: search SMBIOS for OEM board file extension
Date: Thu, 2 Mar 2017 08:53:18 +0000 (UTC) [thread overview]
Message-ID: <20170302085318.3FA5760D5B@smtp.codeaurora.org> (raw)
In-Reply-To: <20170224223003.32156-1-ext.waldemar.rymarkiewicz@tieto.com>
Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com> wrote:
> Board Data File (BDF) is loaded upon driver boot-up procedure. The right
> board data file is identified, among others, by device and sybsystem ids.
>
> The problem, however, can occur when the (default) board data file cannot
> fulfill with the vendor requirements and it is necessary to use a different
> board data file.
>
> To solve the issue QCA uses SMBIOS type 0xF8 to store Board Data File Name
> Extension to specify the extension/variant name. The driver will take the
> extension suffix into consideration and will load the right (non-default)
> board data file if necessary.
>
> If it is unnecessary to use extension board data file, please leave the
> SMBIOS field blank and default configuration will be used.
>
> Example:
> If a default board data file for a specific board is identified by a string
> "bus=pci,vendor=168c,device=003e,subsystem-vendor=1028,
> subsystem-device=0310"
> then the OEM specific data file, if used, could be identified by variant
> suffix:
> "bus=pci,vendor=168c,device=003e,subsystem-vendor=1028,
> subsystem-device=0310,variant=DE_1AB"
>
> If board data file name extension is set but board-2.bin does not contain
> board data file for the variant, the driver will fallback to the default
> board data file not to break backward compatibility.
>
> This was first applied in commit f2593cb1b291 ("ath10k: Search SMBIOS for OEM
> board file extension") but later reverted in commit 005c3490e9db ("Revert
> "ath10k: Search SMBIOS for OEM board file extension"") due to a regression.
> This patch is now otherwise the same as commit f2593cb1b291 except the
> regression fixed.
>
> Signed-off-by: Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com>
Patch applied to wireless-drivers.git, thanks.
1657b8f84ed9 ath10k: search SMBIOS for OEM board file extension
--
https://patchwork.kernel.org/patch/9591335/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-03-02 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 22:30 [PATCH v4] ath10k: search SMBIOS for OEM board file extension Waldemar Rymarkiewicz
2017-03-02 8:53 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302085318.3FA5760D5B@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ext.waldemar.rymarkiewicz@tieto.com \
--cc=jouni@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).