From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrea Ghittino <aghittino@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ganesh.krishna@microchip.com, aditya.shankar@microchip.com
Subject: Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment
Date: Tue, 7 Mar 2017 20:24:38 +0300 [thread overview]
Message-ID: <20170307172438.GI4171@mwanda> (raw)
In-Reply-To: <20170307172304.GH4171@mwanda>
On Tue, Mar 07, 2017 at 08:23:04PM +0300, Dan Carpenter wrote:
> This commit doesn't tell me if you though about what you are doing at
> all. We get so many commits where people just randomly do random endian
> things... Did you think about this? Could you resend with a better
> commit message?
>
The commit message should say what the user visible effects of this
bug fix are going to be.
regards,
dan carpenter
prev parent reply other threads:[~2017-03-07 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 21:11 [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment Andrea Ghittino
2017-03-07 17:23 ` Dan Carpenter
2017-03-07 17:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307172438.GI4171@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aditya.shankar@microchip.com \
--cc=aghittino@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).