From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] mac80211: rt2x00: add support for MT7620
Date: Tue, 14 Mar 2017 11:36:47 +0100 [thread overview]
Message-ID: <20170314103646.GA2622@redhat.com> (raw)
In-Reply-To: <20170311193011.GA6809@makrotopia.org>
On Sat, Mar 11, 2017 at 08:30:23PM +0100, Daniel Golle wrote:
> From: Roman Yeryomin <roman@advem.lv>
>
> Basic support for MT7620 built-in wireless radio was added to
> OpenWrt in r41441. It has seen some heavy cleaning and refactoring
> since in order to match the Kernel's code quality standards.
> Signed-off-by: Roman Yeryomin <roman@advem.lv>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Good job!
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
> tx_pin should only be modified as higher bits contain setting polarity
> for external LNA and PA which should not be reset. If you believe it
> would cause regressions, let's only read it for RT6352 and set it to 0
> for all other chips.
I checked patch on various RTxxxx USB devices and do not find
any regression, beside this was also tested with OpenWRT on various
SOCs, so I think it is ok
Thanks
Stanislaw
next prev parent reply other threads:[~2017-03-14 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 12:32 [PATCH] mac80211: rt2x00: add support for MT7620 Daniel Golle
2017-03-11 10:37 ` Stanislaw Gruszka
2017-03-11 19:30 ` Daniel Golle
2017-03-11 20:30 ` Daniel Golle
2017-03-14 10:36 ` Stanislaw Gruszka [this message]
2017-03-16 8:01 ` Kalle Valo
[not found] ` <20170316080104.4949C60DA6@smtp.codeaurora.org>
2017-03-19 6:02 ` Daniel Golle
2017-03-20 17:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314103646.GA2622@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).