linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luca@coelho.fi>
Cc: axboe@kernel.dk, linux-wireless@vger.kernel.org,
	torvalds@linux-foundation.org, johannes.berg@intel.com,
	emmanuel.grumbach@intel.com, linuxwifi@intel.com,
	sara.sharon@intel.com, liad.kaufman@intel.com,
	luciano.coelho@intel.com
Subject: Re: [RESEND,4.11] iwlwifi: mvm: cleanup pending frames in DQA mode
Date: Thu, 16 Mar 2017 07:54:18 +0000 (UTC)	[thread overview]
Message-ID: <20170316075418.D00DF6028B@smtp.codeaurora.org> (raw)
In-Reply-To: <20170314075035.19248-1-luca@coelho.fi>

Luciano Coelho <luca@coelho.fi> wrote:
> From: Sara Sharon <sara.sharon@intel.com>
> 
> When a station is asleep, the fw will set it as "asleep".
> All queues that are used only by one station will be stopped by
> the fw.
> 
> In pre-DQA mode this was relevant for aggregation queues. However,
> in DQA mode a queue is owned by one station only, so all queues
> will be stopped.
> As a result, we don't expect to get filtered frames back to
> mac80211 and don't have to maintain the entire pending_frames
> state logic, the same way as we do in aggregations.
> 
> The correct behavior is to align DQA behavior with the aggregation
> queue behaviour pre-DQA:
> - Don't count pending frames.
> - Let mac80211 know we have frames in these queues so that it can
> properly handle trigger frames.
> 
> When a trigger frame is received, mac80211 tells the driver to send
> frames from the queues using release_buffered_frames.
> The driver will tell the fw to let frames out even if the station
> is asleep. This is done by iwl_mvm_sta_modify_sleep_tx_count.
> 
> Reported-and-tested-by: Jens Axboe <axboe@kernel.dk>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Sara Sharon <sara.sharon@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Patch applied to wireless-drivers.git, thanks.

9a3fcf912ef7 iwlwifi: mvm: cleanup pending frames in DQA mode

-- 
https://patchwork.kernel.org/patch/9622617/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2017-03-16  7:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f2bedfee-e74f-47d6-9088-94171f0e5538@email.android.com>
2017-03-02  4:10 ` WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450 Jens Axboe
2017-03-10  4:41   ` Jens Axboe
2017-03-10 12:01     ` Luca Coelho
2017-03-10 12:02       ` Coelho, Luciano
2017-03-10 15:23       ` Jens Axboe
2017-03-10 15:36         ` Luca Coelho
2017-03-10 15:41           ` Jens Axboe
2017-03-13 13:00             ` Luca Coelho
2017-03-13 13:14               ` [PATCH] iwlwifi: mvm: cleanup pending frames in DQA mode Luca Coelho
2017-03-13 14:24                 ` Jens Axboe
2017-03-13 15:08                   ` Luca Coelho
2017-03-13 14:23               ` WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450 Jens Axboe
2017-03-14  7:50               ` [RESEND PATCH 4.11] iwlwifi: mvm: cleanup pending frames in DQA mode Luca Coelho
2017-03-15  9:52                 ` Kalle Valo
2017-03-15  9:54                   ` Coelho, Luciano
2017-03-16  7:54                 ` Kalle Valo [this message]
     [not found]         ` <eeb29124-0955-c2df-e39b-3981d76740a7@kernel.dk>
2017-03-10 15:42           ` WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450 Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316075418.D00DF6028B@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=axboe@kernel.dk \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=liad.kaufman@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    --cc=sara.sharon@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).