From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
<linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org,
Brian Norris <briannorris@chromium.org>
Subject: Re: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()
Date: Mon, 20 Mar 2017 17:04:56 +0000 (UTC) [thread overview]
Message-ID: <20170320170456.83A596084C@smtp.codeaurora.org> (raw)
In-Reply-To: <20170307204746.6294-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> We shouldn't be printing a kernel pointer as a decimal integer. But we
> really shouldn't be printing this case at all; we should never get here
> with NULL drvdata. We've eliminated this unnecessary conditional in
> several other places, so kill it here too.
>
> Similarly, there's no need to check for '!pdev'; we are guaranteed to
> have a real device here.
>
> And finally, use dev_err() instead of pr_err().
>
> This yields (for failed PCIe resets):
>
> [ 68.286586] mwifiex_pcie 0000:01:00.0: mwifiex_pcie_reset_notify: adapter structure is not valid
>
> instead of:
>
> [ 82.932658] mwifiex_pcie: mwifiex_pcie_reset_notify: Card or adapter structure is not valid (-270880688088)
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
520334156213 mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()
--
https://patchwork.kernel.org/patch/9609861/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-03-20 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 20:47 [PATCH] mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify() Brian Norris
2017-03-20 17:04 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320170456.83A596084C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).