* [PATCH 4.12] bcma: drop unneeded check for CONFIG_OF_IRQ
@ 2017-03-03 10:33 Rafał Miłecki
2017-03-03 10:46 ` Arnd Bergmann
2017-03-20 17:11 ` [4.12] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2017-03-03 10:33 UTC (permalink / raw)
To: Kalle Valo, linux-wireless
Cc: Hauke Mehrtens, Rafał Miłecki, Arnd Bergmann
From: Rafał Miłecki <rafal@milecki.pl>
We already have the same check in bcma_of_get_irq which really calls
symbols available with CONFIG_OF_IRQ only. It appears this duplicated
check was accidentally added in commit c58d900cc96a ("bcma: fix building
without OF_IRQ"). The rest of code in bcma_of_fill_device should work
fine without CONFIG_OF_IRQ.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Cc: Arnd Bergmann <arnd@arndb.de>
---
drivers/bcma/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index 2da7fe1d20a7..e6986c7608f1 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -201,9 +201,6 @@ static void bcma_of_fill_device(struct device *parent,
{
struct device_node *node;
- if (!IS_ENABLED(CONFIG_OF_IRQ))
- return;
-
node = bcma_of_find_child_device(parent, core);
if (node)
core->dev.of_node = node;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 4.12] bcma: drop unneeded check for CONFIG_OF_IRQ
2017-03-03 10:33 [PATCH 4.12] bcma: drop unneeded check for CONFIG_OF_IRQ Rafał Miłecki
@ 2017-03-03 10:46 ` Arnd Bergmann
2017-03-20 17:11 ` [4.12] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-03-03 10:46 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Kalle Valo, linux-wireless, Hauke Mehrtens,
Rafał Miłecki
On Fri, Mar 3, 2017 at 11:33 AM, Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com>=
wrote:
> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> We already have the same check in bcma_of_get_irq which really calls
> symbols available with CONFIG_OF_IRQ only. It appears this duplicated
> check was accidentally added in commit c58d900cc96a ("bcma: fix building
> without OF_IRQ"). The rest of code in bcma_of_fill_device should work
> fine without CONFIG_OF_IRQ.
>
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [4.12] bcma: drop unneeded check for CONFIG_OF_IRQ
2017-03-03 10:33 [PATCH 4.12] bcma: drop unneeded check for CONFIG_OF_IRQ Rafał Miłecki
2017-03-03 10:46 ` Arnd Bergmann
@ 2017-03-20 17:11 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-03-20 17:11 UTC (permalink / raw)
To: Rafał Miłecki
Cc: linux-wireless, Hauke Mehrtens, Rafał Miłecki,
Arnd Bergmann
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> We already have the same check in bcma_of_get_irq which really calls
> symbols available with CONFIG_OF_IRQ only. It appears this duplicated
> check was accidentally added in commit c58d900cc96a ("bcma: fix building
> without OF_IRQ"). The rest of code in bcma_of_fill_device should work
> fine without CONFIG_OF_IRQ.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to wireless-drivers-next.git, thanks.
48d197765534 bcma: drop unneeded check for CONFIG_OF_IRQ
--
https://patchwork.kernel.org/patch/9602523/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-20 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-03 10:33 [PATCH 4.12] bcma: drop unneeded check for CONFIG_OF_IRQ Rafał Miłecki
2017-03-03 10:46 ` Arnd Bergmann
2017-03-20 17:11 ` [4.12] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).