From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52954 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843AbdCTROU (ORCPT ); Mon, 20 Mar 2017 13:14:20 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: brcmfmac: always print error when PSM's watchdog fires From: Kalle Valo In-Reply-To: <20170224163246.7748-1-zajec5@gmail.com> References: <20170224163246.7748-1-zajec5@gmail.com> To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Message-Id: <20170320171402.33B39609F7@smtp.codeaurora.org> (sfid-20170320_181425_324136_43E42487) Date: Mon, 20 Mar 2017 17:14:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we were attaching BRCMF_E_PSM_WATCHDOG event listener in > brcmf_debug_attach which gets compiled only with CONFIG_BRCMDBG. This > event means something went wrong and firmware / hardware usually can't > be expected to work (reliably). > > Such a problem is significant for user experience so I believe we should > print an error unconditionally (even with debugging disabled). What can > be indeed optional is dumping bus memory as this is clearly part of > debugging process. > > In the future we may also try to extend this listener by trying to > recover from the error or at least signal it to the cfg80211. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. f1ac3aa212af brcmfmac: always print error when PSM's watchdog fires -- https://patchwork.kernel.org/patch/9590763/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches