* [PATCH] drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing
@ 2017-03-24 4:38 Pushkar Jambhlekar
2017-03-24 6:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-24 4:38 UTC (permalink / raw)
To: Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Cc: open list:STAGING - WILC1000 WIFI DRIVER,
open list:STAGING SUBSYSTEM, open list, Pushkar Jambhlekar
dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c
index ad4eb0f..20dbc21 100644
--- a/drivers/staging/wilc1000/wilc_sdio.c
+++ b/drivers/staging/wilc1000/wilc_sdio.c
@@ -74,7 +74,7 @@ static int wilc_sdio_cmd52(struct wilc *wilc, struct sdio_cmd52 *cmd)
sdio_release_host(func);
if (ret)
- dev_err(&func->dev, "wilc_sdio_cmd52..failed, err(%d)\n", ret);
+ dev_err(&func->dev, "%s..failed, err(%d)\n", __func__, ret);
return ret;
}
@@ -103,7 +103,7 @@ static int wilc_sdio_cmd53(struct wilc *wilc, struct sdio_cmd53 *cmd)
sdio_release_host(func);
if (ret)
- dev_err(&func->dev, "wilc_sdio_cmd53..failed, err(%d)\n", ret);
+ dev_err(&func->dev, "%s..failed, err(%d)\n", __func__, ret);
return ret;
}
@@ -243,15 +243,11 @@ static void wilc_sdio_disable_interrupt(struct wilc *dev)
struct sdio_func *func = container_of(dev->dev, struct sdio_func, dev);
int ret;
- dev_dbg(&func->dev, "wilc_sdio_disable_interrupt IN\n");
-
sdio_claim_host(func);
ret = sdio_release_irq(func);
if (ret < 0)
dev_err(&func->dev, "can't release sdio_irq, err(%d)\n", ret);
sdio_release_host(func);
-
- dev_info(&func->dev, "wilc_sdio_disable_interrupt OUT\n");
}
/********************************************
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing
2017-03-24 4:38 [PATCH] drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing Pushkar Jambhlekar
@ 2017-03-24 6:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-24 6:33 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Aditya Shankar, Ganesh Krishna, open list:STAGING SUBSYSTEM,
open list:STAGING - WILC1000 WIFI DRIVER, open list
On Fri, Mar 24, 2017 at 10:08:41AM +0530, Pushkar Jambhlekar wrote:
> dev_err: replacing function name with '%s' and __func__
> dev_dbg: Removing calls which are used for tracing a function.
That's two different things, so you need to send two different patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-24 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-24 4:38 [PATCH] drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing Pushkar Jambhlekar
2017-03-24 6:33 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).