linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: rtlwifi: Fix scheduling while atomic splat
Date: Thu, 30 Mar 2017 16:43:28 +0000 (UTC)	[thread overview]
Message-ID: <20170330164328.9B06860DB4@smtp.codeaurora.org> (raw)
In-Reply-To: <20170321142411.24044-1-Larry.Finger@lwfinger.net>

Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Following commit cceb0a597320 ("rtlwifi: Add work queue for c2h cmd."),
> the following BUG is reported when rtl8723be is used:
> 
> BUG: sleeping function called from invalid context at mm/slab.h:432
> in_atomic(): 1, irqs_disabled(): 1, pid: 0, name: swapper/0
> CPU: 0 PID: 0 Comm: swapper/0 Tainted: G        W  O    4.11.0-rc3-wl+ #276
> Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.50   09/29/2014
> Call Trace:
>  <IRQ>
>  dump_stack+0x63/0x89
>  ___might_sleep+0xe9/0x130
>  __might_sleep+0x4a/0x90
>  kmem_cache_alloc_trace+0x19f/0x200
>  ? rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi]
>  rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi]
>  rtl8723be_c2h_packet_handler+0xac/0xc0 [rtl8723be]
>  rtl8723be_rx_command_packet+0x37/0x5c [rtl8723be]
>  _rtl_pci_rx_interrupt+0x200/0x6b0 [rtl_pci]
>  _rtl_pci_interrupt+0x20c/0x5d0 [rtl_pci]
>  __handle_irq_event_percpu+0x3f/0x1d0
>  handle_irq_event_percpu+0x23/0x60
>  handle_irq_event+0x3c/0x60
>  handle_fasteoi_irq+0xa2/0x170
>  handle_irq+0x20/0x30
>  do_IRQ+0x48/0xd0
>  common_interrupt+0x89/0x89
> ...
> 
> Although commit cceb0a597320 converted most c2h commands to use a work
> queue, the Bluetooth coexistence routines can be in atomic mode when
> they execute such a call.
> 
> Fixes: cceb0a597320 ("rtlwifi: Add work queue for c2h cmd.")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers.git, thanks.

893dc68f1b18 rtlwifi: Fix scheduling while atomic splat

-- 
https://patchwork.kernel.org/patch/9636661/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      parent reply	other threads:[~2017-03-30 16:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 14:24 [PATCH] rtlwifi: Fix scheduling while atomic splat Larry Finger
2017-03-21 17:32 ` Kalle Valo
2017-03-30 16:43 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330164328.9B06860DB4@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).