From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC 0/3] netlink: extended error reporting
Date: Fri, 7 Apr 2017 21:45:57 +0200 [thread overview]
Message-ID: <20170407194557.GA23613@salvia> (raw)
In-Reply-To: <1491593357.5800.13.camel@sipsolutions.net>
On Fri, Apr 07, 2017 at 09:29:17PM +0200, Johannes Berg wrote:
> On Fri, 2017-04-07 at 21:21 +0200, Pablo Neira Ayuso wrote:
> > I think the most flexible way is to pass the container error
> > structure to nla_parse() so it sets this for you. This would also
> > save tons of "malformed attribute" strings.
>
> Yes, for sure. The thing is we'll probalby have to pass down the
> request skb *and* the error struct so that we can get the offset, and
> this seems like the generic thing that we really should try to get the
> most information generated.
We only need to store the pointer to the attribute in the error
container structure. We can calculate the offset from nl_err() by
pasing the skbuff as parameter there, right?
next prev parent reply other threads:[~2017-04-07 19:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:26 [RFC 0/3] netlink: extended error reporting Johannes Berg
2017-04-07 18:26 ` [RFC 1/3] " Johannes Berg
2017-04-07 19:41 ` Johannes Berg
2017-04-07 18:26 ` [RFC 2/3] genetlink: pass extended error report down Johannes Berg
2017-04-07 18:37 ` Ben Greear
2017-04-07 19:12 ` Johannes Berg
2017-04-07 19:27 ` Ben Greear
2017-04-07 18:26 ` [RFC 3/3] nl80211: add a few extended error strings Johannes Berg
2017-04-07 18:53 ` [RFC 0/3] netlink: extended error reporting David Miller
2017-04-07 18:59 ` Johannes Berg
2017-04-07 19:06 ` Pablo Neira Ayuso
2017-04-07 19:09 ` Johannes Berg
2017-04-07 19:21 ` Pablo Neira Ayuso
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:45 ` Pablo Neira Ayuso [this message]
2017-04-07 19:47 ` Johannes Berg
2017-04-07 19:34 ` David Miller
2017-04-07 19:22 ` David Miller
2017-04-07 19:27 ` Pablo Neira Ayuso
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:34 ` David Miller
2017-04-07 19:20 ` David Miller
2017-04-07 19:26 ` Johannes Berg
2017-04-07 19:35 ` Pablo Neira Ayuso
2017-04-07 19:43 ` David Miller
2017-04-07 19:46 ` Johannes Berg
2017-04-07 19:55 ` David Miller
2017-04-07 20:27 ` Johannes Berg
2017-04-07 19:02 ` Pablo Neira Ayuso
2017-04-07 19:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407194557.GA23613@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).