* [PATCH] staging: rtl8188eu: force driver to be built as a module
@ 2017-04-11 9:19 Hans de Goede
2017-04-11 11:30 ` Arend Van Spriel
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2017-04-11 9:19 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Hans de Goede, Larry Finger, linux-wireless
The rtl8188eu driver defines a ton of global symbols which tend to
conflict with other realtek wifi drivers, force it to be built as
a module.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/staging/rtl8188eu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
index 94f3879..cb836c5 100644
--- a/drivers/staging/rtl8188eu/Kconfig
+++ b/drivers/staging/rtl8188eu/Kconfig
@@ -1,6 +1,7 @@
config R8188EU
tristate "Realtek RTL8188EU Wireless LAN NIC driver"
depends on WLAN && USB && CFG80211
+ depends on m
select WIRELESS_EXT
select WEXT_PRIV
---help---
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8188eu: force driver to be built as a module
2017-04-11 9:19 [PATCH] staging: rtl8188eu: force driver to be built as a module Hans de Goede
@ 2017-04-11 11:30 ` Arend Van Spriel
2017-04-11 13:59 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Arend Van Spriel @ 2017-04-11 11:30 UTC (permalink / raw)
To: Hans de Goede, Greg Kroah-Hartman; +Cc: Larry Finger, linux-wireless
On 11-4-2017 11:19, Hans de Goede wrote:
> The rtl8188eu driver defines a ton of global symbols which tend to
> conflict with other realtek wifi drivers, force it to be built as
> a module.
Or get rid of those globals as we did to get out of staging :-p
Regards,
Arend
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/staging/rtl8188eu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
> index 94f3879..cb836c5 100644
> --- a/drivers/staging/rtl8188eu/Kconfig
> +++ b/drivers/staging/rtl8188eu/Kconfig
> @@ -1,6 +1,7 @@
> config R8188EU
> tristate "Realtek RTL8188EU Wireless LAN NIC driver"
> depends on WLAN && USB && CFG80211
> + depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> ---help---
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8188eu: force driver to be built as a module
2017-04-11 11:30 ` Arend Van Spriel
@ 2017-04-11 13:59 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-11 13:59 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: Hans de Goede, Larry Finger, linux-wireless
On Tue, Apr 11, 2017 at 01:30:16PM +0200, Arend Van Spriel wrote:
> On 11-4-2017 11:19, Hans de Goede wrote:
> > The rtl8188eu driver defines a ton of global symbols which tend to
> > conflict with other realtek wifi drivers, force it to be built as
> > a module.
>
> Or get rid of those globals as we did to get out of staging :-p
Give it time...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-11 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 9:19 [PATCH] staging: rtl8188eu: force driver to be built as a module Hans de Goede
2017-04-11 11:30 ` Arend Van Spriel
2017-04-11 13:59 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).