From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Benc <jbenc@redhat.com>,
jiri@resnulli.us
Subject: Re: [PATCH v3 1/5] netlink: extended ACK reporting
Date: Tue, 11 Apr 2017 19:31:43 +0200 [thread overview]
Message-ID: <20170411173143.GA1899@salvia> (raw)
In-Reply-To: <9a68aa01-474c-7054-30c2-473ee1250abe@cumulusnetworks.com>
On Tue, Apr 11, 2017 at 08:25:57AM -0600, David Ahern wrote:
> On 4/11/17 1:02 AM, Johannes Berg wrote:
> > On Tue, 2017-04-11 at 08:59 +0200, Pablo Neira Ayuso wrote:
> >> CAP_ACK means: trim off the payload that the netlink error message
> >> is embedding, just like ICMP error does.
> >>
> >> What is exactly your concern? If the user explicitly requests this
> >> via socket option for this socket, then we're expecting they do the
> >> right handling for what they're asking for.
> >
> > I think David's concern was that when you want to parse the ACK in a
> > library (or application), you may not easily know if the application
> > (or library) requested capping.
>
> exactly.
Then, the library needs to be extended to enable this handling to
modify the way it needs to handle errors, together with the
setsockopt().
next prev parent reply other threads:[~2017-04-11 17:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 20:24 [PATCH v3 0/5] netlink extended ACK reporting Johannes Berg
2017-04-08 20:24 ` [PATCH v3 1/5] netlink: " Johannes Berg
2017-04-10 15:26 ` David Ahern
2017-04-10 15:30 ` Johannes Berg
2017-04-10 15:35 ` David Ahern
2017-04-10 15:40 ` Johannes Berg
2017-04-10 18:38 ` Johannes Berg
2017-04-11 6:59 ` Pablo Neira Ayuso
2017-04-11 7:02 ` Johannes Berg
2017-04-11 14:25 ` David Ahern
2017-04-11 17:31 ` Pablo Neira Ayuso [this message]
2017-04-11 17:42 ` David Miller
2017-04-11 18:57 ` David Ahern
2017-04-11 19:05 ` David Miller
2017-04-11 19:12 ` David Ahern
2017-04-11 19:43 ` Johannes Berg
2017-04-08 20:24 ` [PATCH v3 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 20:24 ` [PATCH v3 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 20:24 ` [PATCH v3 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 20:24 ` [PATCH v3 5/5] netlink: pass extended ACK struct where available Johannes Berg
2017-04-10 11:20 ` [PATCH v3 0/5] netlink extended ACK reporting Johannes Berg
2017-04-10 11:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411173143.GA1899@salvia \
--to=pablo@netfilter.org \
--cc=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).