From: Greg KH <gregkh@linuxfoundation.org>
To: Aditya Shankar <aditya.shankar@microchip.com>
Cc: devel@driverdev.osuosl.org, ganesh.krishna@microchip.com,
arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler
Date: Tue, 18 Apr 2017 13:51:23 +0200 [thread overview]
Message-ID: <20170418115123.GB17911@kroah.com> (raw)
In-Reply-To: <20170413081423.333c25fa@aditya-ubuntu>
On Thu, Apr 13, 2017 at 08:14:23AM +0530, Aditya Shankar wrote:
> On Tue, 11 Apr 2017 19:35:46 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote:
> > > Change the config packet format used in handle_set_wfi_drv_handler()
> > > to align the host driver with the new format used in the wilc firmware.
> >
> > So does this break devices with "old" firmware?
> >
> > Where is the "new" firmware? What is enforcing the usage only of new
> > firmware?
> >
> > thanks,
> >
> > greg k-h
>
> Yes, this new change would break devices with firmware older than ver 14.2(released on our vendor tree in March 2016). The older firmware in the linux-firmware repository is close to 2 years old and not being used with the staging driver even before this change was submitted. Developers picked up the firmware mostly from one of our vendor trees on github.
>
> To resolve this confusion about firmware location, I submitted a patch to linux-firmware to make the latest firmware available through this channel. Below are the details. The driver currently does not enforce usage of new firmware but would fail to properly configure the older firmware.
Please put that information in the changelog text for the next version
of this patch that you submit.
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-18 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 16:41 [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler Aditya Shankar
2017-04-11 17:35 ` Greg KH
2017-04-13 2:44 ` Aditya Shankar
2017-04-18 11:51 ` Greg KH [this message]
2017-04-18 11:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418115123.GB17911@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aditya.shankar@microchip.com \
--cc=arend.vanspriel@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).