Re: [PATCH] rt2x00: remove unneccesary code

Re: [PATCH] rt2x00: remove unneccesary code

[Daniel Golle]

Hi Tom,

thank you for that contribution.
Code for ePA has not yet been submitted upstream, I wanted to give it
some more testing, so it's still a local patch in OpenWrt/LEDE.
I'll merge your patch into our local patch-queue and submit it together
with the ePA code once it got some more testing.

Cheers

Daniel

Patchworkers: consider this to be a request to defer this submission.


On Thu, May 18, 2017 at 12:42:14PM +0200, Tom Psyborg wrote:
> Use chanreg and dccal helpers to reduce the size of ePA code.
> 
> Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
> 
> ---

Re: [PATCH] rt2x00: remove unneccesary code

[Daniel Golle]

Done. See
https://git.lede-project.org/?p=source.git;a=commit;h=5e5499c612a667837c714fc4a41b7347e334ce14

I'll merge it into the patch adding support for ePA and then submit the
already reduced version upstream once it got sufficient testing.

Note that your mailer program destroyed the white-space formatting of
the patch which I had to fix manually as a consequence of that (tabs
were replaced by spaces, hence the patch didn't apply). Try to setup
git-send-email using SMTP directly in order to avoid that in future.

Cheers

Daniel


On Thu, May 18, 2017 at 01:32:38PM +0200, Tom Psyborg wrote:
> Oh, i missed that. It's fine as long as it gets merged in LEDE so it's
> ready for upstreaming.
> 
> On 18 May 2017 at 13:27, Daniel Golle <daniel@makrotopia.org> wrote:
> 
> > Hi Tom,
> >
> > thank you for that contribution.
> > Code for ePA has not yet been submitted upstream, I wanted to give it
> > some more testing, so it's still a local patch in OpenWrt/LEDE.
> > I'll merge your patch into our local patch-queue and submit it together
> > with the ePA code once it got some more testing.
> >
> > Cheers
> >
> > Daniel
> >
> > Patchworkers: consider this to be a request to defer this submission.
> >
> >
> > On Thu, May 18, 2017 at 12:42:14PM +0200, Tom Psyborg wrote:
> > > Use chanreg and dccal helpers to reduce the size of ePA code.
> > >
> > > Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
> > >
> > > ---
> >

Re: [PATCH] rt2x00: remove unneccesary code

[Kalle Valo]

(fixing top posting)

Daniel Golle <daniel@makrotopia.org> writes:

> On Thu, May 18, 2017 at 12:42:14PM +0200, Tom Psyborg wrote:
>> Use chanreg and dccal helpers to reduce the size of ePA code.
>>=20
>> Signed-off-by: Tomislav Po=C5=BEega <pozega.tomislav@gmail.com>
>
> thank you for that contribution.
> Code for ePA has not yet been submitted upstream, I wanted to give it
> some more testing, so it's still a local patch in OpenWrt/LEDE.
> I'll merge your patch into our local patch-queue and submit it together
> with the ePA code once it got some more testing.
>
> Patchworkers: consider this to be a request to defer this submission.

This patch was sent in HTML format so it didn't get to mailing list and
hence neither to patchwork.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes#format_issues

--=20
Kalle Valo

Re: [PATCH] rt2x00: remove unneccesary code

[Kalle Valo]

Tom Psyborg <pozega.tomislav@gmail.com> writes:

> On 18 May 2017 at 14:12, Daniel Golle <daniel@makrotopia.org> wrote:
>
>     Note that your mailer program destroyed the white-space formatting
>     of
>     the patch which I had to fix manually as a consequence of that
>     (tabs
>     were replaced by spaces, hence the patch didn't apply). Try to
>     setup
>     git-send-email using SMTP directly in order to avoid that in
>     future.
>     
>     Cheers
>
> I had same issues when tried sending to openwrt list, what i notice
> is, altough it is HTML patch i can copy it from my browser gmail into
> gedit without whitespace damaging. If i try Show original it shows up
> as whitespace damaged. If using evolution client to send patch it is
> other way round: shows up as damaged in gmail, but fine when click
> Show Original. i will try reinstalling evolution later.

Trying to use evolution or gmail web interface is waste of time, both
yours and us. Like Daniel said, switch to git send-email and you can say
goodbye to all formatting problmes.

-- 
Kalle Valo