From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Colin King <colin.king@canonical.com>
Cc: Avinash Patil <avinashp@quantenna.com>,
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Kalle Valo <kvalo@codeaurora.org>,
Huizhao Wang <hwang@quantenna.com>,
Kamlesh Rath <krath@quantenna.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac
Date: Thu, 25 May 2017 16:56:24 +0300 [thread overview]
Message-ID: <20170525135624.z723srd7evhml5e3@bars> (raw)
In-Reply-To: <20170525134503.12106-1-colin.king@canonical.com>
> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> index fc0ce2c09097..e3c090008125 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
> void qtnf_virtual_intf_cleanup(struct net_device *ndev)
> {
> struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
> - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
Thanks !
Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
next prev parent reply other threads:[~2017-05-25 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 13:45 [PATCH][net-next] qtnfmac: remove duplicated assignment to mac Colin King
2017-05-25 13:56 ` Sergey Matyukevich [this message]
2017-06-01 9:50 ` [net-next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525135624.z723srd7evhml5e3@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=avinashp@quantenna.com \
--cc=colin.king@canonical.com \
--cc=hwang@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krath@quantenna.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).