From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@linux-mips.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
"Brian Norris" <computersforpeace@gmail.com>
Subject: Re: [PATCH] bcm47xx: fix build regression
Date: Wed, 31 May 2017 11:15:41 +0200 [thread overview]
Message-ID: <20170531111541.0ce9a99d@bbrezillon> (raw)
In-Reply-To: <20170530112027.3983554-1-arnd@arndb.de>
On Tue, 30 May 2017 13:20:12 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> An unknown change in the kernel headers caused a build regression
> in an MTD partition driver:
>
> In file included from drivers/mtd/bcm47xxpart.c:12:0:
> include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem':
> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first use in this function)
>
> Clearly we want to include linux/errno.h here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> include/linux/bcm47xx_nvram.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/bcm47xx_nvram.h b/include/linux/bcm47xx_nvram.h
> index 2793652fbf66..a414a2b53e41 100644
> --- a/include/linux/bcm47xx_nvram.h
> +++ b/include/linux/bcm47xx_nvram.h
> @@ -8,6 +8,7 @@
> #ifndef __BCM47XX_NVRAM_H
> #define __BCM47XX_NVRAM_H
>
> +#include <linux/errno.h>
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/vmalloc.h>
next prev parent reply other threads:[~2017-05-31 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 11:20 [PATCH] bcm47xx: fix build regression Arnd Bergmann
2017-05-31 9:15 ` Boris Brezillon [this message]
2017-05-31 9:43 ` Arend van Spriel
2017-05-31 10:21 ` Arnd Bergmann
2017-05-31 13:12 ` Paul E. McKenney
2017-05-31 13:34 ` Arnd Bergmann
2017-05-31 16:31 ` Paul E. McKenney
2017-05-31 19:30 ` Arend van Spriel
2017-06-01 22:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531111541.0ce9a99d@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).