From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Brian Norris" <computersforpeace@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:RALINK MIPS ARCHITECTURE" <linux-mips@linux-mips.org>,
"Ingo Molnar" <mingo@kernel.org>
Subject: Re: [PATCH] bcm47xx: fix build regression
Date: Wed, 31 May 2017 06:12:16 -0700 [thread overview]
Message-ID: <20170531131216.GJ3956@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAK8P3a2-kO==gMDm3E6U8CR-zhwmZGztRy7Trcezf8oZxgn01g@mail.gmail.com>
On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote:
> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel
> <arend.vanspriel@broadcom.com> wrote:
> > On 5/30/2017 1:20 PM, Arnd Bergmann wrote:
> >>
> >> An unknown change in the kernel headers caused a build regression
> >> in an MTD partition driver:
> >>
> >> In file included from drivers/mtd/bcm47xxpart.c:12:0:
> >> include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem':
> >> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first
> >> use in this function)
> >>
> >> Clearly we want to include linux/errno.h here.
> >
> >
> > unfortunate that you did not find the commit that caused this build
> > regression. You could produce preprocessor output when it was working to see
> > where errno.h got implicitly included and start looking there for git
> > history.
>
> I did a 'git bisect run make drivers/mtd/bcm47xxpart.o' now, which pointed to
> 0bc2d534708b ("rcu: Refactor #includes from include/linux/rcupdate.h").
>
> That commit seems reasonable, it was just bad luck that it caused this
> regression. The commit is currently in the rcu/rcu/next branch of tip.git,
> so Paul could merge the patch there.
Apologies for the inconvenience, not sure why 0day test robot didn't
find this. Probably because it cannot test each and every driver. ;-)
This patch, correct?
https://lkml.org/lkml/2017/5/30/348
Thanx, Paul
next prev parent reply other threads:[~2017-05-31 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 11:20 [PATCH] bcm47xx: fix build regression Arnd Bergmann
2017-05-31 9:15 ` Boris Brezillon
2017-05-31 9:43 ` Arend van Spriel
2017-05-31 10:21 ` Arnd Bergmann
2017-05-31 13:12 ` Paul E. McKenney [this message]
2017-05-31 13:34 ` Arnd Bergmann
2017-05-31 16:31 ` Paul E. McKenney
2017-05-31 19:30 ` Arend van Spriel
2017-06-01 22:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531131216.GJ3956@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arend.vanspriel@broadcom.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).