From: "Tobin C. Harding" <me@tobin.cc>
To: Greg KH <greg@kroah.com>
Cc: linux-wireless@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Tycho Andersen <tycho@tycho.ws>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory
Date: Thu, 1 Jun 2017 14:09:47 +1000 [thread overview]
Message-ID: <20170601040947.GC30618@eros> (raw)
In-Reply-To: <20170601034537.GA7468@kroah.com>
On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote:
> On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote:
> > Current driver implements the WEXT interface. WEXT is in maintenance
> > mode, we need to re-write the driver using cfg80211. The current
> > driver is handy as a reference for the new implementation, we can keep
> > it in tree for now.
> >
> > Move WEXT driver to sub directory, add dummy Makefile and Kconfig so
> > build completes successfully but does not process any files from the
> > WEXT directory.
> >
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > ---
> > drivers/staging/ks7010/Kconfig | 6 +-
> > drivers/staging/ks7010/Makefile | 3 -
> > drivers/staging/ks7010/TODO | 36 -
> > drivers/staging/ks7010/eap_packet.h | 144 --
> > drivers/staging/ks7010/ks7010_sdio.c | 1079 ----------
> > drivers/staging/ks7010/ks7010_sdio.h | 164 --
> > drivers/staging/ks7010/ks_hostif.c | 2638 -----------------------
> > drivers/staging/ks7010/ks_hostif.h | 685 ------
> > drivers/staging/ks7010/ks_wlan.h | 514 -----
> > drivers/staging/ks7010/ks_wlan_ioctl.h | 67 -
> > drivers/staging/ks7010/ks_wlan_net.c | 2999 ---------------------------
> > drivers/staging/ks7010/michael_mic.c | 148 --
> > drivers/staging/ks7010/michael_mic.h | 25 -
> > drivers/staging/ks7010/wext/Kconfig | 10 +
> > drivers/staging/ks7010/wext/Makefile | 4 +
> > drivers/staging/ks7010/wext/TODO | 36 +
> > drivers/staging/ks7010/wext/eap_packet.h | 144 ++
> > drivers/staging/ks7010/wext/ks7010_sdio.c | 1079 ++++++++++
> > drivers/staging/ks7010/wext/ks7010_sdio.h | 164 ++
> > drivers/staging/ks7010/wext/ks_hostif.c | 2638 +++++++++++++++++++++++
> > drivers/staging/ks7010/wext/ks_hostif.h | 685 ++++++
> > drivers/staging/ks7010/wext/ks_wlan.h | 514 +++++
> > drivers/staging/ks7010/wext/ks_wlan_ioctl.h | 67 +
> > drivers/staging/ks7010/wext/ks_wlan_net.c | 2999 +++++++++++++++++++++++++++
> > drivers/staging/ks7010/wext/michael_mic.c | 148 ++
> > drivers/staging/ks7010/wext/michael_mic.h | 25 +
> > 26 files changed, 8514 insertions(+), 8507 deletions(-)
> > delete mode 100644 drivers/staging/ks7010/TODO
> > delete mode 100644 drivers/staging/ks7010/eap_packet.h
> > delete mode 100644 drivers/staging/ks7010/ks7010_sdio.c
> > delete mode 100644 drivers/staging/ks7010/ks7010_sdio.h
> > delete mode 100644 drivers/staging/ks7010/ks_hostif.c
> > delete mode 100644 drivers/staging/ks7010/ks_hostif.h
> > delete mode 100644 drivers/staging/ks7010/ks_wlan.h
> > delete mode 100644 drivers/staging/ks7010/ks_wlan_ioctl.h
> > delete mode 100644 drivers/staging/ks7010/ks_wlan_net.c
> > delete mode 100644 drivers/staging/ks7010/michael_mic.c
> > delete mode 100644 drivers/staging/ks7010/michael_mic.h
> > create mode 100644 drivers/staging/ks7010/wext/Kconfig
> > create mode 100644 drivers/staging/ks7010/wext/Makefile
> > create mode 100644 drivers/staging/ks7010/wext/TODO
> > create mode 100644 drivers/staging/ks7010/wext/eap_packet.h
> > create mode 100644 drivers/staging/ks7010/wext/ks7010_sdio.c
> > create mode 100644 drivers/staging/ks7010/wext/ks7010_sdio.h
> > create mode 100644 drivers/staging/ks7010/wext/ks_hostif.c
> > create mode 100644 drivers/staging/ks7010/wext/ks_hostif.h
> > create mode 100644 drivers/staging/ks7010/wext/ks_wlan.h
> > create mode 100644 drivers/staging/ks7010/wext/ks_wlan_ioctl.h
> > create mode 100644 drivers/staging/ks7010/wext/ks_wlan_net.c
> > create mode 100644 drivers/staging/ks7010/wext/michael_mic.c
> > create mode 100644 drivers/staging/ks7010/wext/michael_mic.h
>
> Please use the -M option to 'git format-patch" so that we can just see
> file moves, not delete/add like you have here.
Point noted, will submit v2 using -M option. This is the second time
you have told me this, that means I have to buy you a beer doesn't it?
Will follow the 'wait a day before submitting next version' rule.
thanks,
Tobin.
next prev parent reply other threads:[~2017-06-01 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 3:27 [RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL Tobin C. Harding
2017-06-01 3:27 ` [RFC 1/3] staging: ks7010: move WEXT files to sub directory Tobin C. Harding
2017-06-01 3:45 ` Greg KH
2017-06-01 4:09 ` Tobin C. Harding [this message]
2017-06-01 3:27 ` [RFC 2/3] staging: ks7010: add cfg80211 files Tobin C. Harding
2017-06-01 3:27 ` [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010 Tobin C. Harding
2017-06-01 3:46 ` Greg KH
2017-06-01 4:02 ` Joe Perches
2017-06-01 4:10 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601040947.GC30618@eros \
--to=me@tobin.cc \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tycho@tycho.ws \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).