From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Ping-Ke Shih <pkshih@realtek.com>,
Birming Chiu <birming@realtek.com>, Shaofu <shaofu@realtek.com>,
Steven Ting <steventing@realtek.com>,
lkp@intel.com
Subject: Re: [v2,1/7] rtlwifi: btcoex: update new btcoex version
Date: Thu, 1 Jun 2017 09:41:59 +0000 (UTC) [thread overview]
Message-ID: <20170601094159.E09236074A@smtp.codeaurora.org> (raw)
In-Reply-To: <20170526184147.31239-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> This patch updates the btcoexist to a newer version with some callbacks.
>
> Specific issues fixed are
> pre_load_firmware()
> fix the unstable issues before FW is ready
> power_on_seting()
> fix the unstable issues before HW is ready
> Some notify finctions, check hardware type and call corresponding
> functions to specific chip
>
> As noted by the kbuild test robot <lkp@intel.com>, there was a missing
> global. This problem has been fixed.
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Birming Chiu <birming@realtek.com>
> Cc: Shaofu <shaofu@realtek.com>
> Cc: Steven Ting <steventing@realtek.com>
> Cc: lkp@intel.com
There are two red flags which immediately caught my attention: "update to a
newer version" and listing multiple changes in the commit log. A patch should
have one logical change but this one seems to have a lot of changes which makes
it difficult to track what has changed. This definitely should split into
smaller patches.
I'll still try to commit patches 2-7, hopefully they don't depend on anything
in this patch.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/9750977/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-06-01 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 18:41 [PATCH v2 0/7] rtlwifi: btcoex: Final round of fixes Larry Finger
2017-05-26 18:41 ` [PATCH v2 1/7] rtlwifi: btcoex: update new btcoex version Larry Finger
2017-06-01 9:41 ` Kalle Valo [this message]
2017-05-26 18:41 ` [PATCH v2 2/7] rtlwifi: btcoex: fix compiler warnings for unused functions Larry Finger
2017-06-01 9:54 ` [v2, " Kalle Valo
2017-05-26 18:41 ` [PATCH v2 3/7] rtlwifi: btcoex: bind bt to the adapter when initialization Larry Finger
2017-05-26 18:41 ` [PATCH v2 4/7] rtlwifi: btcoex: Remove duplicate test in if statement Larry Finger
2017-05-26 18:41 ` [PATCH v2 5/7] rtlwifi: btcoex: Fix Sparse messages for undeclared symbols Larry Finger
2017-05-26 18:41 ` [PATCH v2 6/7] rtlwifi: btcoex: Fix logic error in 21a 1ant Larry Finger
2017-05-26 18:41 ` [PATCH v2 7/7] rtlwifi: btcoex: Fix another edit mistake " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601094159.E09236074A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=birming@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pkshih@realtek.com \
--cc=shaofu@realtek.com \
--cc=steventing@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).